Commit 59a6b7d4 authored by Omer Katz's avatar Omer Katz Committed by Commit Bot

cppgc: Fix perfetto build

When V8_USE_PERFETTO is defined, TracingController doesn't have
AddTraceEvent and GetCategoryGroupEnabled methods.

Bug: v8:11203
Change-Id: I05d7ff829d8b134662bc1dbe4cb56bb740185918
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562381
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71442}
parent f2316c87
...@@ -17,22 +17,24 @@ namespace internal { ...@@ -17,22 +17,24 @@ namespace internal {
namespace testing { namespace testing {
class DelegatingTracingController : public TracingController { class DelegatingTracingController : public TracingController {
public: public:
virtual const uint8_t* GetCategoryGroupEnabled(const char* name) { #if !defined(V8_USE_PERFETTO)
const uint8_t* GetCategoryGroupEnabled(const char* name) override {
static uint8_t yes = 1; static uint8_t yes = 1;
return &yes; return &yes;
} }
virtual uint64_t AddTraceEvent( uint64_t AddTraceEvent(
char phase, const uint8_t* category_enabled_flag, const char* name, char phase, const uint8_t* category_enabled_flag, const char* name,
const char* scope, uint64_t id, uint64_t bind_id, int32_t num_args, const char* scope, uint64_t id, uint64_t bind_id, int32_t num_args,
const char** arg_names, const uint8_t* arg_types, const char** arg_names, const uint8_t* arg_types,
const uint64_t* arg_values, const uint64_t* arg_values,
std::unique_ptr<ConvertableToTraceFormat>* arg_convertables, std::unique_ptr<ConvertableToTraceFormat>* arg_convertables,
unsigned int flags) { unsigned int flags) override {
return tracing_controller_->AddTraceEvent( return tracing_controller_->AddTraceEvent(
phase, category_enabled_flag, name, scope, id, bind_id, num_args, phase, category_enabled_flag, name, scope, id, bind_id, num_args,
arg_names, arg_types, arg_values, arg_convertables, flags); arg_names, arg_types, arg_values, arg_convertables, flags);
} }
#endif // !defined(V8_USE_PERFETTO)
void SetTracingController( void SetTracingController(
std::unique_ptr<TracingController> tracing_controller_impl) { std::unique_ptr<TracingController> tracing_controller_impl) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment