[inspector] enabled presubmit for inspector sub folder

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2343733002
Cr-Commit-Position: refs/heads/master@{#39727}

src/inspector/injected-script-native.h

@@ -5,12 +5,12 @@
 #ifndef V8_INSPECTOR_INJECTEDSCRIPTNATIVE_H_
 #define V8_INSPECTOR_INJECTEDSCRIPTNATIVE_H_
 
+#include <vector>
+
 #include "src/inspector/protocol/Protocol.h"
 
 #include "include/v8.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 class InjectedScriptNative final {

src/inspector/injected-script.h

@@ -52,8 +52,6 @@ using protocol::ErrorString;
 using protocol::Maybe;
 
 class InjectedScript final {
-  DISALLOW_COPY_AND_ASSIGN(InjectedScript);
-
  public:
   static std::unique_ptr<InjectedScript> create(InspectedContext*);
   ~InjectedScript();
@@ -141,8 +139,6 @@ class InjectedScript final {
   };
 
   class ContextScope : public Scope {
-    DISALLOW_COPY_AND_ASSIGN(ContextScope);
-
    public:
     ContextScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
                  int executionContextId);
@@ -151,11 +147,11 @@ class InjectedScript final {
    private:
     void findInjectedScript(V8InspectorSessionImpl*) override;
     int m_executionContextId;
+
+    DISALLOW_COPY_AND_ASSIGN(ContextScope);
   };
 
   class ObjectScope : public Scope {
-    DISALLOW_COPY_AND_ASSIGN(ObjectScope);
-
    public:
     ObjectScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
                 const String16& remoteObjectId);
@@ -168,11 +164,11 @@ class InjectedScript final {
     String16 m_remoteObjectId;
     String16 m_objectGroupName;
     v8::Local<v8::Value> m_object;
+
+    DISALLOW_COPY_AND_ASSIGN(ObjectScope);
   };
 
   class CallFrameScope : public Scope {
-    DISALLOW_COPY_AND_ASSIGN(CallFrameScope);
-
    public:
     CallFrameScope(ErrorString*, V8InspectorImpl*, int contextGroupId,
                    const String16& remoteCallFrameId);
@@ -183,6 +179,8 @@ class InjectedScript final {
     void findInjectedScript(V8InspectorSessionImpl*) override;
     String16 m_remoteCallFrameId;
     size_t m_frameOrdinal;
+
+    DISALLOW_COPY_AND_ASSIGN(CallFrameScope);
   };
 
  private:
@@ -200,6 +198,8 @@ class InjectedScript final {
   v8::Global<v8::Value> m_lastEvaluationResult;
   std::unique_ptr<InjectedScriptNative> m_native;
   v8::Global<v8::Object> m_commandLineAPI;
+
+  DISALLOW_COPY_AND_ASSIGN(InjectedScript);
 };
 
 }  // namespace v8_inspector

src/inspector/inspected-context.h

@@ -18,8 +18,6 @@ class V8ContextInfo;
 class V8InspectorImpl;
 
 class InspectedContext {
-  DISALLOW_COPY_AND_ASSIGN(InspectedContext);
-
  public:
   ~InspectedContext();
 
@@ -57,6 +55,8 @@ class InspectedContext {
   bool m_reported;
   std::unique_ptr<InjectedScript> m_injectedScript;
   v8::Global<v8::Object> m_console;
+
+  DISALLOW_COPY_AND_ASSIGN(InspectedContext);
 };
 
 }  // namespace v8_inspector

src/inspector/java-script-call-frame.h

@@ -31,18 +31,16 @@
 #ifndef V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
 #define V8_INSPECTOR_JAVASCRIPTCALLFRAME_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/protocol-platform.h"
 
 #include "include/v8.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 class JavaScriptCallFrame {
-  DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame);
-
  public:
   static std::unique_ptr<JavaScriptCallFrame> create(
       v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame) {
@@ -73,6 +71,8 @@ class JavaScriptCallFrame {
   v8::Isolate* m_isolate;
   v8::Global<v8::Context> m_debuggerContext;
   v8::Global<v8::Object> m_callFrame;
+
+  DISALLOW_COPY_AND_ASSIGN(JavaScriptCallFrame);
 };
 
 using JavaScriptCallFrames = std::vector<std::unique_ptr<JavaScriptCallFrame>>;

src/inspector/string-16.cc

@@ -3,8 +3,6 @@
 // found in the LICENSE file.
 
 #include "src/inspector/string-16.h"
-#include "src/base/platform/platform.h"
-#include "src/inspector/protocol-platform.h"
 
 #include <algorithm>
 #include <cctype>
@@ -14,6 +12,9 @@
 #include <locale>
 #include <string>
 
+#include "src/base/platform/platform.h"
+#include "src/inspector/protocol-platform.h"
+
 namespace v8_inspector {
 
 namespace {
@@ -38,7 +39,8 @@ int charactersToInteger(const UChar* characters, size_t length,
   buffer.push_back('\0');
 
   char* endptr;
-  long result = std::strtol(buffer.data(), &endptr, 10);
+  int64_t result =
+      static_cast<int64_t>(std::strtol(buffer.data(), &endptr, 10));
   if (ok) {
     *ok = !(*endptr) && result <= std::numeric_limits<int>::max() &&
           result >= std::numeric_limits<int>::min();
@@ -84,17 +86,17 @@ ConversionResult convertUTF16ToUTF8(const UChar** sourceStart,
   char* target = *targetStart;
   while (source < sourceEnd) {
     UChar32 ch;
-    unsigned short bytesToWrite = 0;
+    uint32_t bytesToWrite = 0;
     const UChar32 byteMask = 0xBF;
     const UChar32 byteMark = 0x80;
     const UChar* oldSource =
         source;  // In case we have to back up because of target overflow.
-    ch = static_cast<unsigned short>(*source++);
+    ch = static_cast<uint16_t>(*source++);
     // If we have a surrogate pair, convert to UChar32 first.
     if (ch >= 0xD800 && ch <= 0xDBFF) {
       // If the 16 bits following the high surrogate are in the source buffer...
       if (source < sourceEnd) {
-        UChar32 ch2 = static_cast<unsigned short>(*source);
+        UChar32 ch2 = static_cast<uint16_t>(*source);
         // If it's a low surrogate, convert to UChar32.
         if (ch2 >= 0xDC00 && ch2 <= 0xDFFF) {
           ch = ((ch - 0xD800) << 10) + (ch2 - 0xDC00) + 0x0010000;
@@ -140,16 +142,16 @@ ConversionResult convertUTF16ToUTF8(const UChar** sourceStart,
     }
     switch (bytesToWrite) {  // note: everything falls through.
       case 4:
-        *--target = (char)((ch | byteMark) & byteMask);
+        *--target = static_cast<char>((ch | byteMark) & byteMask);
         ch >>= 6;
       case 3:
-        *--target = (char)((ch | byteMark) & byteMask);
+        *--target = static_cast<char>((ch | byteMark) & byteMask);
         ch >>= 6;
       case 2:
-        *--target = (char)((ch | byteMark) & byteMask);
+        *--target = static_cast<char>((ch | byteMark) & byteMask);
         ch >>= 6;
       case 1:
-        *--target = (char)(ch | firstByteMark[bytesToWrite]);
+        *--target = static_cast<char>(ch | firstByteMark[bytesToWrite]);
     }
     target += bytesToWrite;
   }

src/inspector/string-16.h

@@ -23,8 +23,9 @@ class String16 {
   String16() {}
   String16(const String16& other) : m_impl(other.m_impl) {}
   String16(const UChar* characters, size_t size) : m_impl(characters, size) {}
-  String16(const UChar* characters) : m_impl(characters) {}
-  String16(const char* characters)
+  String16(const UChar* characters)  // NOLINT(runtime/explicit)
+      : m_impl(characters) {}
+  String16(const char* characters)  // NOLINT(runtime/explicit)
       : String16(characters, std::strlen(characters)) {}
   String16(const char* characters, size_t size) {
     m_impl.resize(size);

src/inspector/string-util.h

@@ -57,8 +57,6 @@ StringView toStringView(const String16&);
 bool stringViewStartsWith(const StringView&, const char*);
 
 class StringBufferImpl : public StringBuffer {
-  DISALLOW_COPY_AND_ASSIGN(StringBufferImpl);
-
  public:
   // Destroys string's content.
   static std::unique_ptr<StringBufferImpl> adopt(String16&);
@@ -68,6 +66,8 @@ class StringBufferImpl : public StringBuffer {
   explicit StringBufferImpl(String16&);
   String16 m_owner;
   StringView m_string;
+
+  DISALLOW_COPY_AND_ASSIGN(StringBufferImpl);
 };
 
 }  //  namespace v8_inspector

src/inspector/v8-console-agent-impl.h

@@ -17,8 +17,6 @@ class V8InspectorSessionImpl;
 using protocol::ErrorString;
 
 class V8ConsoleAgentImpl : public protocol::Console::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8ConsoleAgentImpl);
-
  public:
   V8ConsoleAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*,
                      protocol::DictionaryValue* state);
@@ -41,6 +39,8 @@ class V8ConsoleAgentImpl : public protocol::Console::Backend {
   protocol::DictionaryValue* m_state;
   protocol::Console::Frontend m_frontend;
   bool m_enabled;
+
+  DISALLOW_COPY_AND_ASSIGN(V8ConsoleAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-console-message.cc

@@ -76,7 +76,7 @@ class V8ValueStringBuilder {
     IgnoreUndefined = 1 << 1,
   };
 
-  V8ValueStringBuilder(v8::Local<v8::Context> context)
+  explicit V8ValueStringBuilder(v8::Local<v8::Context> context)
       : m_arrayLimit(maxArrayItemsLimit),
         m_isolate(context->GetIsolate()),
         m_tryCatch(context->GetIsolate()),

src/inspector/v8-console.cc

@@ -29,10 +29,8 @@ v8::Local<v8::Private> inspectedContextPrivateKey(v8::Isolate* isolate) {
 }
 
 class ConsoleHelper {
-  DISALLOW_COPY_AND_ASSIGN(ConsoleHelper);
-
  public:
-  ConsoleHelper(const v8::FunctionCallbackInfo<v8::Value>& info)
+  explicit ConsoleHelper(const v8::FunctionCallbackInfo<v8::Value>& info)
       : m_info(info),
         m_isolate(info.GetIsolate()),
         m_context(info.GetIsolate()->GetCurrentContext()),
@@ -241,6 +239,8 @@ class ConsoleHelper {
       return defaultValue;
     return false;
   }
+
+  DISALLOW_COPY_AND_ASSIGN(ConsoleHelper);
 };
 
 void returnDataCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {

src/inspector/v8-console.h

@@ -24,8 +24,6 @@ class V8Console {
   static v8::Local<v8::Object> createCommandLineAPI(InspectedContext*);
 
   class CommandLineAPIScope {
-    DISALLOW_COPY_AND_ASSIGN(CommandLineAPIScope);
-
    public:
     CommandLineAPIScope(v8::Local<v8::Context>,
                         v8::Local<v8::Object> commandLineAPI,
@@ -44,6 +42,8 @@ class V8Console {
     v8::Local<v8::Object> m_global;
     v8::Local<v8::Set> m_installedMethods;
     bool m_cleanup;
+
+    DISALLOW_COPY_AND_ASSIGN(CommandLineAPIScope);
   };
 
  private:

src/inspector/v8-debugger-agent-impl.cc

@@ -4,6 +4,8 @@
 
 #include "src/inspector/v8-debugger-agent-impl.h"
 
+#include <algorithm>
+
 #include "src/inspector/injected-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/java-script-call-frame.h"
@@ -22,8 +24,6 @@
 
 #include "include/v8-inspector.h"
 
-#include <algorithm>
-
 namespace v8_inspector {
 
 using protocol::Array;
@@ -50,7 +50,7 @@ static const char columnNumber[] = "columnNumber";
 static const char condition[] = "condition";
 static const char skipAllPauses[] = "skipAllPauses";
 
-}  // namespace DebuggerAgentState;
+}  // namespace DebuggerAgentState
 
 static const int maxSkipStepFrameCount = 128;
 static const char backtraceObjectGroup[] = "backtrace";

src/inspector/v8-debugger-agent-impl.h

@@ -5,13 +5,13 @@
 #ifndef V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
 #define V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/java-script-call-frame.h"
 #include "src/inspector/protocol/Debugger.h"
 #include "src/inspector/protocol/Forward.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 struct ScriptBreakpoint;
@@ -28,8 +28,6 @@ using protocol::ErrorString;
 using protocol::Maybe;
 
 class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl);
-
  public:
   enum SkipPauseRequest {
     RequestNoSkip,
@@ -217,6 +215,8 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
   std::unique_ptr<V8Regex> m_blackboxPattern;
   protocol::HashMap<String16, std::vector<std::pair<int, int>>>
       m_blackboxedPositions;
+
+  DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-debugger-script.h

@@ -38,8 +38,6 @@
 namespace v8_inspector {
 
 class V8DebuggerScript {
-  DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript);
-
  public:
   V8DebuggerScript(v8::Local<v8::Context>, v8::Local<v8::Object>,
                    bool isLiveEdit);
@@ -80,6 +78,8 @@ class V8DebuggerScript {
   int m_executionContextId;
   String16 m_executionContextAuxData;
   bool m_isLiveEdit;
+
+  DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-debugger.h

@@ -5,6 +5,8 @@
 #ifndef V8_INSPECTOR_V8DEBUGGER_H_
 #define V8_INSPECTOR_V8DEBUGGER_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/java-script-call-frame.h"
 #include "src/inspector/protocol/Forward.h"
@@ -14,8 +16,6 @@
 #include "include/v8-debug.h"
 #include "include/v8-inspector.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 struct ScriptBreakpoint;
@@ -26,8 +26,6 @@ class V8StackTraceImpl;
 using protocol::ErrorString;
 
 class V8Debugger {
-  DISALLOW_COPY_AND_ASSIGN(V8Debugger);
-
  public:
   V8Debugger(v8::Isolate*, V8InspectorImpl*);
   ~V8Debugger();
@@ -153,6 +151,8 @@ class V8Debugger {
   std::vector<void*> m_currentTasks;
   std::vector<std::unique_ptr<V8StackTraceImpl>> m_currentStacks;
   protocol::HashMap<V8DebuggerAgentImpl*, int> m_maxAsyncCallStackDepthMap;
+
+  DISALLOW_COPY_AND_ASSIGN(V8Debugger);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-heap-profiler-agent-impl.cc

@@ -30,7 +30,7 @@ static const char samplingHeapProfilerInterval[] =
 
 class HeapSnapshotProgress final : public v8::ActivityControl {
  public:
-  HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
+  explicit HeapSnapshotProgress(protocol::HeapProfiler::Frontend* frontend)
       : m_frontend(frontend) {}
   ControlOption ReportProgressValue(int done, int total) override {
     m_frontend->reportHeapSnapshotProgress(done, total,
@@ -78,7 +78,7 @@ class GlobalObjectNameResolver final
 
 class HeapSnapshotOutputStream final : public v8::OutputStream {
  public:
-  HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
+  explicit HeapSnapshotOutputStream(protocol::HeapProfiler::Frontend* frontend)
       : m_frontend(frontend) {}
   void EndOfStream() override {}
   int GetChunkSize() override { return 102400; }
@@ -113,7 +113,7 @@ class InspectableHeapObject final : public V8InspectorSession::Inspectable {
 
 class HeapStatsStream final : public v8::OutputStream {
  public:
-  HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
+  explicit HeapStatsStream(protocol::HeapProfiler::Frontend* frontend)
       : m_frontend(frontend) {}
 
   void EndOfStream() override {}

src/inspector/v8-heap-profiler-agent-impl.h

@@ -19,8 +19,6 @@ using protocol::ErrorString;
 using protocol::Maybe;
 
 class V8HeapProfilerAgentImpl : public protocol::HeapProfiler::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8HeapProfilerAgentImpl);
-
  public:
   V8HeapProfilerAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*,
                           protocol::DictionaryValue* state);
@@ -66,6 +64,8 @@ class V8HeapProfilerAgentImpl : public protocol::HeapProfiler::Backend {
   protocol::HeapProfiler::Frontend m_frontend;
   protocol::DictionaryValue* m_state;
   bool m_hasTimer;
+
+  DISALLOW_COPY_AND_ASSIGN(V8HeapProfilerAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-inspector-impl.h

@@ -31,14 +31,14 @@
 #ifndef V8_INSPECTOR_V8INSPECTORIMPL_H_
 #define V8_INSPECTOR_V8INSPECTORIMPL_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/protocol/Protocol.h"
 
 #include "include/v8-debug.h"
 #include "include/v8-inspector.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 class InspectedContext;
@@ -51,8 +51,6 @@ class V8RuntimeAgentImpl;
 class V8StackTraceImpl;
 
 class V8InspectorImpl : public V8Inspector {
-  DISALLOW_COPY_AND_ASSIGN(V8InspectorImpl);
-
  public:
   V8InspectorImpl(v8::Isolate*, V8InspectorClient*);
   ~V8InspectorImpl() override;
@@ -143,6 +141,8 @@ class V8InspectorImpl : public V8Inspector {
   using ConsoleStorageMap =
       protocol::HashMap<int, std::unique_ptr<V8ConsoleMessageStorage>>;
   ConsoleStorageMap m_consoleStorageMap;
+
+  DISALLOW_COPY_AND_ASSIGN(V8InspectorImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-inspector-session-impl.h

@@ -5,6 +5,8 @@
 #ifndef V8_INSPECTOR_V8INSPECTORSESSIONIMPL_H_
 #define V8_INSPECTOR_V8INSPECTORSESSIONIMPL_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/protocol/Forward.h"
 #include "src/inspector/protocol/Runtime.h"
@@ -12,8 +14,6 @@
 
 #include "include/v8-inspector.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 class InjectedScript;
@@ -30,8 +30,6 @@ using protocol::ErrorString;
 
 class V8InspectorSessionImpl : public V8InspectorSession,
                                public protocol::FrontendChannel {
-  DISALLOW_COPY_AND_ASSIGN(V8InspectorSessionImpl);
-
  public:
   static std::unique_ptr<V8InspectorSessionImpl> create(
       V8InspectorImpl*, int contextGroupId, V8Inspector::Channel*,
@@ -119,6 +117,8 @@ class V8InspectorSessionImpl : public V8InspectorSession,
   std::unique_ptr<V8SchemaAgentImpl> m_schemaAgent;
   std::vector<std::unique_ptr<V8InspectorSession::Inspectable>>
       m_inspectedObjects;
+
+  DISALLOW_COPY_AND_ASSIGN(V8InspectorSessionImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-profiler-agent-impl.cc

@@ -4,6 +4,8 @@
 
 #include "src/inspector/v8-profiler-agent-impl.h"
 
+#include <vector>
+
 #include "src/base/atomicops.h"
 #include "src/inspector/protocol/Protocol.h"
 #include "src/inspector/string-util.h"
@@ -14,8 +16,6 @@
 
 #include "include/v8-profiler.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 namespace ProfilerAgentState {

src/inspector/v8-profiler-agent-impl.h

@@ -5,12 +5,12 @@
 #ifndef V8_INSPECTOR_V8PROFILERAGENTIMPL_H_
 #define V8_INSPECTOR_V8PROFILERAGENTIMPL_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/protocol/Forward.h"
 #include "src/inspector/protocol/Profiler.h"
 
-#include <vector>
-
 namespace v8 {
 class CpuProfiler;
 class Isolate;
@@ -23,8 +23,6 @@ class V8InspectorSessionImpl;
 using protocol::ErrorString;
 
 class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8ProfilerAgentImpl);
-
  public:
   V8ProfilerAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*,
                       protocol::DictionaryValue* state);
@@ -67,6 +65,8 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
   class ProfileDescriptor;
   std::vector<ProfileDescriptor> m_startedProfiles;
   String16 m_frontendInitiatedProfileId;
+
+  DISALLOW_COPY_AND_ASSIGN(V8ProfilerAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-regex.cc

@@ -4,13 +4,13 @@
 
 #include "src/inspector/v8-regex.h"
 
+#include <limits.h>
+
 #include "src/inspector/string-util.h"
 #include "src/inspector/v8-inspector-impl.h"
 
 #include "include/v8-inspector.h"
 
-#include <limits.h>
-
 namespace v8_inspector {
 
 V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern,

src/inspector/v8-regex.h

@@ -17,8 +17,6 @@ class V8InspectorImpl;
 enum MultilineMode { MultilineDisabled, MultilineEnabled };
 
 class V8Regex {
-  DISALLOW_COPY_AND_ASSIGN(V8Regex);
-
  public:
   V8Regex(V8InspectorImpl*, const String16&, bool caseSensitive,
           bool multiline = false);
@@ -30,6 +28,8 @@ class V8Regex {
   V8InspectorImpl* m_inspector;
   v8::Global<v8::RegExp> m_regex;
   String16 m_errorMessage;
+
+  DISALLOW_COPY_AND_ASSIGN(V8Regex);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-runtime-agent-impl.h

@@ -50,8 +50,6 @@ using protocol::ErrorString;
 using protocol::Maybe;
 
 class V8RuntimeAgentImpl : public protocol::Runtime::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8RuntimeAgentImpl);
-
  public:
   V8RuntimeAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*,
                      protocol::DictionaryValue* state);
@@ -124,6 +122,8 @@ class V8RuntimeAgentImpl : public protocol::Runtime::Backend {
   bool m_enabled;
   protocol::HashMap<String16, std::unique_ptr<v8::Global<v8::Script>>>
       m_compiledScripts;
+
+  DISALLOW_COPY_AND_ASSIGN(V8RuntimeAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-schema-agent-impl.h

@@ -16,8 +16,6 @@ class V8InspectorSessionImpl;
 using protocol::ErrorString;
 
 class V8SchemaAgentImpl : public protocol::Schema::Backend {
-  DISALLOW_COPY_AND_ASSIGN(V8SchemaAgentImpl);
-
  public:
   V8SchemaAgentImpl(V8InspectorSessionImpl*, protocol::FrontendChannel*,
                     protocol::DictionaryValue* state);
@@ -30,6 +28,8 @@ class V8SchemaAgentImpl : public protocol::Schema::Backend {
  private:
   V8InspectorSessionImpl* m_session;
   protocol::Schema::Frontend m_frontend;
+
+  DISALLOW_COPY_AND_ASSIGN(V8SchemaAgentImpl);
 };
 
 }  // namespace v8_inspector

src/inspector/v8-stack-trace-impl.h

@@ -5,14 +5,14 @@
 #ifndef V8_INSPECTOR_V8STACKTRACEIMPL_H_
 #define V8_INSPECTOR_V8STACKTRACEIMPL_H_
 
+#include <vector>
+
 #include "src/base/macros.h"
 #include "src/inspector/protocol/Forward.h"
 #include "src/inspector/protocol/Runtime.h"
 
 #include "include/v8-inspector.h"
 
-#include <vector>
-
 namespace v8_inspector {
 
 class TracedValue;
@@ -23,8 +23,6 @@ class V8Debugger;
 // that current native-only state had some async story.
 // On the other hand, any non-top async stack is guaranteed to be non-empty.
 class V8StackTraceImpl final : public V8StackTrace {
-  DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
-
  public:
   static const size_t maxCallStackSizeToCapture = 200;
 
@@ -92,6 +90,8 @@ class V8StackTraceImpl final : public V8StackTrace {
   String16 m_description;
   std::vector<Frame> m_frames;
   std::unique_ptr<V8StackTraceImpl> m_parent;
+
+  DISALLOW_COPY_AND_ASSIGN(V8StackTraceImpl);
 };
 
 }  // namespace v8_inspector

tools/presubmit.py

@@ -192,9 +192,8 @@ class CppLintProcessor(SourceFileProcessor):
     return name.endswith('.cc') or name.endswith('.h')
 
   def IgnoreDir(self, name):
-    # TODO(dgozman): remove inspector after fixing the issues.
     return (super(CppLintProcessor, self).IgnoreDir(name)
-              or (name == 'third_party') or (name == 'inspector'))
+              or (name == 'third_party'))
 
   IGNORE_LINT = ['flag-definitions.h']