Commit 5458cfd0 authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[wasm][pku] Fix check for write protection

As the comment notes, we want to ensure that code space is *not*
writable by the current thread.

R=jkummerow@chromium.org
CC=mpdenton@chromium.org

Bug: v8:11974
Change-Id: I5c3cad32b8edc56013f298405c8e20d8bc9da05f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173675Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76985}
parent 661654f3
...@@ -257,7 +257,7 @@ V8_WARN_UNUSED_RESULT MaybeHandle<Object> Invoke(Isolate* isolate, ...@@ -257,7 +257,7 @@ V8_WARN_UNUSED_RESULT MaybeHandle<Object> Invoke(Isolate* isolate,
// If we have PKU support for Wasm, ensure that code is currently write // If we have PKU support for Wasm, ensure that code is currently write
// protected for this thread. // protected for this thread.
DCHECK_IMPLIES(wasm::GetWasmCodeManager()->HasMemoryProtectionKeySupport(), DCHECK_IMPLIES(wasm::GetWasmCodeManager()->HasMemoryProtectionKeySupport(),
wasm::GetWasmCodeManager()->MemoryProtectionKeyWritable()); !wasm::GetWasmCodeManager()->MemoryProtectionKeyWritable());
#endif // V8_ENABLE_WEBASSEMBLY #endif // V8_ENABLE_WEBASSEMBLY
#ifdef USE_SIMULATOR #ifdef USE_SIMULATOR
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment