Commit 4e61ba42 authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[wasm-simd][cleanup] Fix some conversion instruction names

These didn't have the right suffix (i32 instead of i32x4).

Also, names are longer now, so when tracing them, give the names column
more space.

Bug: v8:11384
Change-Id: Id11e0d23b344310121ae4e2e5910528cab2d6f73
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673264Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72514}
parent 6e207d8b
...@@ -35,7 +35,7 @@ struct WasmException; ...@@ -35,7 +35,7 @@ struct WasmException;
if (FLAG_trace_wasm_decoder) PrintF(__VA_ARGS__); \ if (FLAG_trace_wasm_decoder) PrintF(__VA_ARGS__); \
} while (false) } while (false)
#define TRACE_INST_FORMAT " @%-8d #%-20s|" #define TRACE_INST_FORMAT " @%-8d #%-30s|"
// Return the evaluation of `condition` if validate==true, DCHECK that it's // Return the evaluation of `condition` if validate==true, DCHECK that it's
// true and always return true otherwise. // true and always return true otherwise.
......
...@@ -253,14 +253,14 @@ constexpr const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) { ...@@ -253,14 +253,14 @@ constexpr const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) {
CASE_F32x4_OP(RecipSqrtApprox, "recip_sqrt_approx") CASE_F32x4_OP(RecipSqrtApprox, "recip_sqrt_approx")
CASE_SIMDF_OP(Min, "min") CASE_SIMDF_OP(Min, "min")
CASE_SIMDF_OP(Max, "max") CASE_SIMDF_OP(Max, "max")
CASE_CONVERT_OP(Convert, F32x4, I32x4, "i32", "convert") CASE_CONVERT_OP(Convert, F32x4, I32x4, "i32x4", "convert")
CASE_CONVERT_OP(Convert, I32x4, F32x4, "f32", "convert") CASE_CONVERT_OP(Convert, I32x4, F32x4, "f32x4", "convert")
CASE_CONVERT_OP(Convert, I32x4, I16x8Low, "i32", "convert") CASE_CONVERT_OP(Convert, I32x4, I16x8Low, "i16x8_low", "convert")
CASE_CONVERT_OP(Convert, I32x4, I16x8High, "i32", "convert") CASE_CONVERT_OP(Convert, I32x4, I16x8High, "i16x8_high", "convert")
CASE_CONVERT_OP(Convert, I16x8, I32x4, "i32", "convert") CASE_CONVERT_OP(Convert, I16x8, I32x4, "i32x4", "convert")
CASE_CONVERT_OP(Convert, I16x8, I8x16Low, "i32", "convert") CASE_CONVERT_OP(Convert, I16x8, I8x16Low, "i8x16_low", "convert")
CASE_CONVERT_OP(Convert, I16x8, I8x16High, "i32", "convert") CASE_CONVERT_OP(Convert, I16x8, I8x16High, "i8x16_high", "convert")
CASE_CONVERT_OP(Convert, I8x16, I16x8, "i32", "convert") CASE_CONVERT_OP(Convert, I8x16, I16x8, "i16x8", "convert")
CASE_SIMDF_OP(ExtractLane, "extract_lane") CASE_SIMDF_OP(ExtractLane, "extract_lane")
CASE_SIMDF_OP(ReplaceLane, "replace_lane") CASE_SIMDF_OP(ReplaceLane, "replace_lane")
CASE_I64x2_OP(ExtractLane, "extract_lane") CASE_I64x2_OP(ExtractLane, "extract_lane")
...@@ -275,8 +275,8 @@ constexpr const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) { ...@@ -275,8 +275,8 @@ constexpr const char* WasmOpcodes::OpcodeName(WasmOpcode opcode) {
CASE_SIGN_OP(SIMDI, Le, "le") CASE_SIGN_OP(SIMDI, Le, "le")
CASE_SIGN_OP(SIMDI, Gt, "gt") CASE_SIGN_OP(SIMDI, Gt, "gt")
CASE_SIGN_OP(SIMDI, Ge, "ge") CASE_SIGN_OP(SIMDI, Ge, "ge")
CASE_CONVERT_OP(Convert, I64x2, I32x4Low, "i32", "convert") CASE_CONVERT_OP(Convert, I64x2, I32x4Low, "i32x4_low", "convert")
CASE_CONVERT_OP(Convert, I64x2, I32x4High, "i32", "convert") CASE_CONVERT_OP(Convert, I64x2, I32x4High, "i32x4_high", "convert")
CASE_SIGN_OP(SIMDI, Shr, "shr") CASE_SIGN_OP(SIMDI, Shr, "shr")
CASE_SIGN_OP(I64x2, Shr, "shr") CASE_SIGN_OP(I64x2, Shr, "shr")
CASE_SIMDI_OP(Shl, "shl") CASE_SIMDI_OP(Shl, "shl")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment