Commit 4e14a2a4 authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

[regexp] Fix fast/slow-path dispatch in RegExp.p.get flags

Flag getters (e.g. RegExp.p.get global) are defined on the prototype and
thus we need to use the more general BranchIfFastRegExp here instead of
IsFastRegExpNoPrototype.

Bug: chromium:800538
Change-Id: Ib6bc8a4fd3bf2f7dd31538c8dbb61814106c184b
Reviewed-on: https://chromium-review.googlesource.com/859767Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50538}
parent c36bbaaf
...@@ -1219,8 +1219,7 @@ TF_BUILTIN(RegExpPrototypeFlagsGetter, RegExpBuiltinsAssembler) { ...@@ -1219,8 +1219,7 @@ TF_BUILTIN(RegExpPrototypeFlagsGetter, RegExpBuiltinsAssembler) {
Node* const receiver = maybe_receiver; Node* const receiver = maybe_receiver;
Label if_isfastpath(this), if_isslowpath(this, Label::kDeferred); Label if_isfastpath(this), if_isslowpath(this, Label::kDeferred);
Branch(IsFastRegExpNoPrototype(context, receiver, map), &if_isfastpath, BranchIfFastRegExp(context, receiver, map, &if_isfastpath, &if_isslowpath);
&if_isslowpath);
BIND(&if_isfastpath); BIND(&if_isfastpath);
Return(FlagsGetter(context, receiver, true)); Return(FlagsGetter(context, receiver, true));
......
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
RegExp.prototype.__defineGetter__("global", () => true);
assertEquals("/()/g", /()/.toString());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment