Commit 487f840e authored by Jakob Gruber's avatar Jakob Gruber Committed by V8 LUCI CQ

[maglev] Remove UNREACHABLE from constexpr functions

gcc builds seem to have troubles with this:

 error: call to non-constexpr function

Remove the UNREACHABLE() calls for now but keep a TODO to
potentially re-enable them again once we've figured this out.

Bug: v8:7700,v8:12667
Change-Id: I9628a1326c1c4200b90aad25cd2eabfeb06608fb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494237
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79314}
parent d693117f
...@@ -27,7 +27,10 @@ constexpr uint8_t MapRegisterToIndex(Register r) { ...@@ -27,7 +27,10 @@ constexpr uint8_t MapRegisterToIndex(Register r) {
count++; count++;
ALWAYS_ALLOCATABLE_GENERAL_REGISTERS(EMIT_BRANCH) ALWAYS_ALLOCATABLE_GENERAL_REGISTERS(EMIT_BRANCH)
#undef EMIT_BRANCH #undef EMIT_BRANCH
UNREACHABLE(); // TODO(v8:7700): Re-enable UNREACHABLE once we figure out how to to avoid
// the gcc error 'call to non-constexpr function'.
// UNREACHABLE();
return 255;
} }
constexpr Register MapIndexToRegister(int i) { constexpr Register MapIndexToRegister(int i) {
...@@ -37,7 +40,10 @@ constexpr Register MapIndexToRegister(int i) { ...@@ -37,7 +40,10 @@ constexpr Register MapIndexToRegister(int i) {
count++; count++;
ALWAYS_ALLOCATABLE_GENERAL_REGISTERS(EMIT_BRANCH) ALWAYS_ALLOCATABLE_GENERAL_REGISTERS(EMIT_BRANCH)
#undef EMIT_BRANCH #undef EMIT_BRANCH
UNREACHABLE(); // TODO(v8:7700): Re-enable UNREACHABLE once we figure out how to to avoid
// the gcc error 'call to non-constexpr function'.
// UNREACHABLE();
return no_reg;
} }
struct RegisterStateFlags { struct RegisterStateFlags {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment