Commit 4551bbd3 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Revert "[wasm] Reenable code logging"

This reverts commit 84d6864a.

Reason for revert: Still observing failures with http/tests/wasm/wasm_worker_termination_while_compiling.html

https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/29821

Original change's description:
> [wasm] Reenable code logging
> 
> Code logging was fixed in https://crrev.com/c/1454598. Reenable it.
> 
> R=​mstarzinger@chromium.org
> CC=​herhut@chromium.org
> 
> Bug: v8:8783
> Change-Id: I50773d4b42ce52e8d078e47a797ab517771c2756
> Reviewed-on: https://chromium-review.googlesource.com/c/1454601
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59394}

TBR=mstarzinger@chromium.org,clemensh@chromium.org

Change-Id: I1ec69d2dbcbb38744174827c0aa1a994dd0df7ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8783
Reviewed-on: https://chromium-review.googlesource.com/c/1456086Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59407}
parent 7584dbf5
...@@ -1568,7 +1568,8 @@ void CompilationStateImpl::OnFinishedUnit(ExecutionTier tier, WasmCode* code) { ...@@ -1568,7 +1568,8 @@ void CompilationStateImpl::OnFinishedUnit(ExecutionTier tier, WasmCode* code) {
} }
} }
if (code != nullptr) native_module_->engine()->LogCode(code); // TODO(clemensh): Fix and reenable code logging (https://crbug.com/v8/8783).
// if (code != nullptr) native_module_->engine()->LogCode(code);
} }
void CompilationStateImpl::RestartBackgroundCompileTask() { void CompilationStateImpl::RestartBackgroundCompileTask() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment