Commit 44436836 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

[serializer] Properly dispose Isolates in tests

Bug: 
Change-Id: I1ca4246174e16dc3577f31a9e3a8333aadc17415
Reviewed-on: https://chromium-review.googlesource.com/702894Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48328}
parent f84d216f
...@@ -203,6 +203,7 @@ UNINITIALIZED_TEST(StartupSerializerOnce) { ...@@ -203,6 +203,7 @@ UNINITIALIZED_TEST(StartupSerializerOnce) {
DisableAlwaysOpt(); DisableAlwaysOpt();
v8::Isolate* isolate = TestIsolate::NewInitialized(true); v8::Isolate* isolate = TestIsolate::NewInitialized(true);
StartupBlobs blobs = Serialize(isolate); StartupBlobs blobs = Serialize(isolate);
isolate->Dispose();
isolate = Deserialize(blobs); isolate = Deserialize(blobs);
blobs.Dispose(); blobs.Dispose();
{ {
...@@ -271,6 +272,7 @@ UNINITIALIZED_TEST(StartupSerializerTwice) { ...@@ -271,6 +272,7 @@ UNINITIALIZED_TEST(StartupSerializerTwice) {
v8::Isolate* isolate = TestIsolate::NewInitialized(true); v8::Isolate* isolate = TestIsolate::NewInitialized(true);
StartupBlobs blobs1 = Serialize(isolate); StartupBlobs blobs1 = Serialize(isolate);
StartupBlobs blobs2 = Serialize(isolate); StartupBlobs blobs2 = Serialize(isolate);
isolate->Dispose();
blobs1.Dispose(); blobs1.Dispose();
isolate = Deserialize(blobs2); isolate = Deserialize(blobs2);
blobs2.Dispose(); blobs2.Dispose();
...@@ -291,6 +293,7 @@ UNINITIALIZED_TEST(StartupSerializerOnceRunScript) { ...@@ -291,6 +293,7 @@ UNINITIALIZED_TEST(StartupSerializerOnceRunScript) {
DisableAlwaysOpt(); DisableAlwaysOpt();
v8::Isolate* isolate = TestIsolate::NewInitialized(true); v8::Isolate* isolate = TestIsolate::NewInitialized(true);
StartupBlobs blobs = Serialize(isolate); StartupBlobs blobs = Serialize(isolate);
isolate->Dispose();
isolate = Deserialize(blobs); isolate = Deserialize(blobs);
blobs.Dispose(); blobs.Dispose();
{ {
...@@ -317,6 +320,7 @@ UNINITIALIZED_TEST(StartupSerializerTwiceRunScript) { ...@@ -317,6 +320,7 @@ UNINITIALIZED_TEST(StartupSerializerTwiceRunScript) {
v8::Isolate* isolate = TestIsolate::NewInitialized(true); v8::Isolate* isolate = TestIsolate::NewInitialized(true);
StartupBlobs blobs1 = Serialize(isolate); StartupBlobs blobs1 = Serialize(isolate);
StartupBlobs blobs2 = Serialize(isolate); StartupBlobs blobs2 = Serialize(isolate);
isolate->Dispose();
blobs1.Dispose(); blobs1.Dispose();
isolate = Deserialize(blobs2); isolate = Deserialize(blobs2);
blobs2.Dispose(); blobs2.Dispose();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment