Commit 40ab666b authored by bradnelson's avatar bradnelson Committed by Commit bot

Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org

Review-Url: https://codereview.chromium.org/2705333005
Cr-Commit-Position: refs/heads/master@{#43397}
parent 990c59d8
...@@ -7,7 +7,8 @@ include_rules = [ ...@@ -7,7 +7,8 @@ include_rules = [
"+src/conversions.h", "+src/conversions.h",
"+src/inspector", "+src/inspector",
"+src/tracing", "+src/tracing",
"-include/v8-debug.h", # TODO(dgozman): Fix includes and re-enable.
#"-include/v8-debug.h",
"+src/debug/debug-interface.h", "+src/debug/debug-interface.h",
"+src/debug/interface-types.h", "+src/debug/interface-types.h",
] ]
...@@ -516,6 +516,11 @@ class StatusFilesProcessor(SourceFileProcessor): ...@@ -516,6 +516,11 @@ class StatusFilesProcessor(SourceFileProcessor):
return success return success
def CheckDeps(workspace):
checkdeps_py = join(workspace, 'buildtools', 'checkdeps', 'checkdeps.py')
return subprocess.call([sys.executable, checkdeps_py, workspace]) == 0
def GetOptions(): def GetOptions():
result = optparse.OptionParser() result = optparse.OptionParser()
result.add_option('--no-lint', help="Do not run cpplint", default=False, result.add_option('--no-lint', help="Do not run cpplint", default=False,
...@@ -528,6 +533,8 @@ def Main(): ...@@ -528,6 +533,8 @@ def Main():
parser = GetOptions() parser = GetOptions()
(options, args) = parser.parse_args() (options, args) = parser.parse_args()
success = True success = True
print "Running checkdeps..."
success &= CheckDeps(workspace)
print "Running C++ lint check..." print "Running C++ lint check..."
if not options.no_lint: if not options.no_lint:
success &= CppLintProcessor().RunOnPath(workspace) success &= CppLintProcessor().RunOnPath(workspace)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment