Commit 40527340 authored by Camillo Bruni's avatar Camillo Bruni Committed by Commit Bot

[tools] map-processor updates

- Show map description for selected maps
- More instructions for detailed investigation

Change-Id: Ia07e847c20cafc52160310c7a358004330d22094
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231356Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68208}
parent eec10a2f
...@@ -1259,7 +1259,8 @@ function transitionTypeToColor(type) { ...@@ -1259,7 +1259,8 @@ function transitionTypeToColor(type) {
<section> <section>
<h2>Instructions</h2> <h2>Instructions</h2>
<p>Visualize Map trees that have been gathered using <code>--trace-maps</code>.</p> <p>Visualize Map trees that have been gathered using <code>path/to/d8 $FILE --trace-maps</code>.</p>
<p>You can inspect the transition tree in DevTools by looking at <code>document.state.timeline.values</code>.
<h3>Keyboard Shortcuts</h3> <h3>Keyboard Shortcuts</h3>
<dl> <dl>
<dt><kbd>SHIFT</kbd> + <kbd>Arrow Up</kbd></dt> <dt><kbd>SHIFT</kbd> + <kbd>Arrow Up</kbd></dt>
......
...@@ -193,9 +193,7 @@ class MapProcessor extends LogReader { ...@@ -193,9 +193,7 @@ class MapProcessor extends LogReader {
processMapDetails(time, id, string) { processMapDetails(time, id, string) {
//TODO(cbruni): fix initial map logging. //TODO(cbruni): fix initial map logging.
let map = this.getExistingMap(id, time); let map = this.getExistingMap(id, time);
if (!map.description) { if (!map.description) map.description = string;
//map.description = string;
}
} }
createMap(id, time) { createMap(id, time) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment