Commit 3fbc94f6 authored by Camillo Bruni's avatar Camillo Bruni Committed by Commit Bot

[log] Fix shared-library logging

The setup order in the logger was slightly off and we skipped on writing
the log entries for the loaded shared-library. This causes a lot of unaccounted
ticks with the ticks-processor.

Bug: v8:11108
Change-Id: I260eb846da4cce0ead7cdb6e90fd0b02d3cd8eaa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517697Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70990}
parent 26f10ecd
......@@ -2068,22 +2068,17 @@ bool Logger::SetUp(Isolate* isolate) {
ticker_ = std::make_unique<Ticker>(isolate, FLAG_prof_sampling_interval);
bool activate_logging = false;
if (Log::InitLogAtStart()) activate_logging = true;
if (Log::InitLogAtStart()) UpdateIsLogging(true);
timer_.Start();
if (FLAG_prof_cpp) {
UpdateIsLogging(true);
profiler_ = std::make_unique<Profiler>(isolate);
activate_logging = true;
profiler_->Engage();
}
if (activate_logging) {
AddCodeEventListener(this);
UpdateIsLogging(true);
}
if (is_logging_) AddCodeEventListener(this);
return true;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment