Commit 3e31cf61 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Fix clang-tidy warnings for missing overrides

Remove a redundant default destructor definition and add final to
another which is overriding a virtual constructor.

Bug: v8:9396
Change-Id: I917f3c6058bfae8cbcd3c4ffb0817f78e8214552
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807360
Commit-Queue: Dan Elphick <delphick@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63822}
parent 2172208d
...@@ -940,7 +940,7 @@ class PipelineCompilationJob final : public OptimizedCompilationJob { ...@@ -940,7 +940,7 @@ class PipelineCompilationJob final : public OptimizedCompilationJob {
PipelineCompilationJob(Isolate* isolate, PipelineCompilationJob(Isolate* isolate,
Handle<SharedFunctionInfo> shared_info, Handle<SharedFunctionInfo> shared_info,
Handle<JSFunction> function); Handle<JSFunction> function);
~PipelineCompilationJob(); ~PipelineCompilationJob() final;
protected: protected:
Status PrepareJobImpl(Isolate* isolate) final; Status PrepareJobImpl(Isolate* isolate) final;
...@@ -1165,8 +1165,6 @@ class WasmHeapStubCompilationJob final : public OptimizedCompilationJob { ...@@ -1165,8 +1165,6 @@ class WasmHeapStubCompilationJob final : public OptimizedCompilationJob {
pipeline_(&data_), pipeline_(&data_),
wasm_engine_(wasm_engine) {} wasm_engine_(wasm_engine) {}
~WasmHeapStubCompilationJob() = default;
protected: protected:
Status PrepareJobImpl(Isolate* isolate) final; Status PrepareJobImpl(Isolate* isolate) final;
Status ExecuteJobImpl() final; Status ExecuteJobImpl() final;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment