Commit 3857757f authored by ulan@chromium.org's avatar ulan@chromium.org

Add myself to CC in merge_to_branch.py

BUG=
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/603113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 5134e35e
...@@ -546,7 +546,8 @@ class UploadStep(Step): ...@@ -546,7 +546,8 @@ class UploadStep(Step):
self.DieNoManualMode("A reviewer must be specified in forced mode.") self.DieNoManualMode("A reviewer must be specified in forced mode.")
reviewer = self.ReadLine() reviewer = self.ReadLine()
self.GitUpload(reviewer, self._options.author, self._options.force_upload, self.GitUpload(reviewer, self._options.author, self._options.force_upload,
bypass_hooks=self._options.bypass_upload_hooks) bypass_hooks=self._options.bypass_upload_hooks,
cc=self._options.cc)
class DetermineV8Sheriff(Step): class DetermineV8Sheriff(Step):
......
...@@ -194,7 +194,7 @@ class GitRecipesMixin(object): ...@@ -194,7 +194,7 @@ class GitRecipesMixin(object):
self.Git(MakeArgs(args), **kwargs) self.Git(MakeArgs(args), **kwargs)
def GitUpload(self, reviewer="", author="", force=False, cq=False, def GitUpload(self, reviewer="", author="", force=False, cq=False,
bypass_hooks=False, **kwargs): bypass_hooks=False, cc="", **kwargs):
args = ["cl upload --send-mail"] args = ["cl upload --send-mail"]
if author: if author:
args += ["--email", Quoted(author)] args += ["--email", Quoted(author)]
...@@ -206,6 +206,8 @@ class GitRecipesMixin(object): ...@@ -206,6 +206,8 @@ class GitRecipesMixin(object):
args.append("--use-commit-queue") args.append("--use-commit-queue")
if bypass_hooks: if bypass_hooks:
args.append("--bypass-hooks") args.append("--bypass-hooks")
if cc:
args += ["-cc", Quoted(cc)]
# TODO(machenbach): Check output in forced mode. Verify that all required # TODO(machenbach): Check output in forced mode. Verify that all required
# base files were uploaded, if not retry. # base files were uploaded, if not retry.
self.Git(MakeArgs(args), pipe=False, **kwargs) self.Git(MakeArgs(args), pipe=False, **kwargs)
......
...@@ -293,6 +293,8 @@ class MergeToBranch(ScriptsBase): ...@@ -293,6 +293,8 @@ class MergeToBranch(ScriptsBase):
print "You must specify a merge comment if no patches are specified" print "You must specify a merge comment if no patches are specified"
return False return False
options.bypass_upload_hooks = True options.bypass_upload_hooks = True
# CC ulan to make sure that fixes are merged to Google3.
options.cc = "ulan@chromium.org"
return True return True
def _Config(self): def _Config(self):
......
...@@ -1138,7 +1138,7 @@ LOG=N ...@@ -1138,7 +1138,7 @@ LOG=N
Cmd("git commit -aF \"%s\"" % TEST_CONFIG["COMMITMSG_FILE"], ""), Cmd("git commit -aF \"%s\"" % TEST_CONFIG["COMMITMSG_FILE"], ""),
RL("reviewer@chromium.org"), # V8 reviewer. RL("reviewer@chromium.org"), # V8 reviewer.
Cmd("git cl upload --send-mail -r \"reviewer@chromium.org\" " Cmd("git cl upload --send-mail -r \"reviewer@chromium.org\" "
"--bypass-hooks", ""), "--bypass-hooks -cc \"ulan@chromium.org\"", ""),
Cmd("git checkout -f %s" % TEST_CONFIG["BRANCHNAME"], ""), Cmd("git checkout -f %s" % TEST_CONFIG["BRANCHNAME"], ""),
RL("LGTM"), # Enter LGTM for V8 CL. RL("LGTM"), # Enter LGTM for V8 CL.
Cmd("git cl presubmit", "Presubmit successfull\n"), Cmd("git cl presubmit", "Presubmit successfull\n"),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment