Commit 335d1625 authored by Sigurd Schneider's avatar Sigurd Schneider Committed by Commit Bot

[cctest] Bump max old space size for isolate creation

Bump limit for isolate creation in cctest; the test started crashing recently
on nosnap.debug builds, hence we bump the limit.

Bug: v8:7856
Change-Id: I7c2396c7f112a2ed7fc189f0fa72658e0ed75050
Reviewed-on: https://chromium-review.googlesource.com/1104691Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53816}
parent 0181cf0b
...@@ -116,9 +116,6 @@ ...@@ -116,9 +116,6 @@
'test-api/SecondaryStubCache': [SKIP], 'test-api/SecondaryStubCache': [SKIP],
'test-api/AccessCheckInIC': [SKIP], 'test-api/AccessCheckInIC': [SKIP],
# BUG(7856)
'test-api/InitializeDefaultIsolateOnSecondaryThread1': [SKIP],
# BUG(3742). # BUG(3742).
'test-mark-compact/MarkCompactCollector': [PASS, ['arch==arm', NO_VARIANTS]], 'test-mark-compact/MarkCompactCollector': [PASS, ['arch==arm', NO_VARIANTS]],
......
...@@ -20829,7 +20829,7 @@ class InitDefaultIsolateThread : public v8::base::Thread { ...@@ -20829,7 +20829,7 @@ class InitDefaultIsolateThread : public v8::base::Thread {
switch (testCase_) { switch (testCase_) {
case SetResourceConstraints: { case SetResourceConstraints: {
create_params.constraints.set_max_semi_space_size_in_kb(1024); create_params.constraints.set_max_semi_space_size_in_kb(1024);
create_params.constraints.set_max_old_space_size(6); create_params.constraints.set_max_old_space_size(8);
break; break;
} }
default: default:
...@@ -20878,28 +20878,23 @@ static void InitializeTestHelper(InitDefaultIsolateThread::TestCase testCase) { ...@@ -20878,28 +20878,23 @@ static void InitializeTestHelper(InitDefaultIsolateThread::TestCase testCase) {
CHECK(thread.result()); CHECK(thread.result());
} }
TEST(InitializeDefaultIsolateOnSecondaryThread_ResourceConstraints) {
TEST(InitializeDefaultIsolateOnSecondaryThread1) {
InitializeTestHelper(InitDefaultIsolateThread::SetResourceConstraints); InitializeTestHelper(InitDefaultIsolateThread::SetResourceConstraints);
} }
TEST(InitializeDefaultIsolateOnSecondaryThread_FatalHandler) {
TEST(InitializeDefaultIsolateOnSecondaryThread2) {
InitializeTestHelper(InitDefaultIsolateThread::SetFatalHandler); InitializeTestHelper(InitDefaultIsolateThread::SetFatalHandler);
} }
TEST(InitializeDefaultIsolateOnSecondaryThread_CounterFunction) {
TEST(InitializeDefaultIsolateOnSecondaryThread3) {
InitializeTestHelper(InitDefaultIsolateThread::SetCounterFunction); InitializeTestHelper(InitDefaultIsolateThread::SetCounterFunction);
} }
TEST(InitializeDefaultIsolateOnSecondaryThread_CreateHistogramFunction) {
TEST(InitializeDefaultIsolateOnSecondaryThread4) {
InitializeTestHelper(InitDefaultIsolateThread::SetCreateHistogramFunction); InitializeTestHelper(InitDefaultIsolateThread::SetCreateHistogramFunction);
} }
TEST(InitializeDefaultIsolateOnSecondaryThread_AddHistogramSampleFunction) {
TEST(InitializeDefaultIsolateOnSecondaryThread5) {
InitializeTestHelper(InitDefaultIsolateThread::SetAddHistogramSampleFunction); InitializeTestHelper(InitDefaultIsolateThread::SetAddHistogramSampleFunction);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment