Commit 2cdbb99b authored by Richard Townsend's avatar Richard Townsend Committed by Commit Bot

[arm64][msvc] Fix the embedded snapshot writer for Windows on Arm, MSVC

Suffered from a confusion of masm/marmasm syntax for the x64 host and
arm64 target (could only generate one syntax or ther other). Fixed by
moving the compile-time flag to a runtime one.

Bug: v8:10012

Change-Id: I34746a495b1881c1d0465995930979bb768b07e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962854Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#66650}
parent b4712802
......@@ -66,6 +66,7 @@ class PlatformEmbeddedFileWriterWin : public PlatformEmbeddedFileWriterBase {
private:
void DeclareSymbolGlobal(const char* name);
const char* DirectiveAsString(DataDirective directive);
private:
const EmbeddedTargetArch target_arch_;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment