Commit 2a0bc36d authored by gengjiawen's avatar gengjiawen Committed by V8 LUCI CQ

[parser] Fix the MSVC build

MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString
method despite it being unused. This CL adds an (unreachable)
definition for it.

Bug: v8:12266
Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77313}
parent 64e0bcff
......@@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
return arg;
}
const AstRawString* PreParserIdentifierToAstRawString(
const PreParserIdentifier& arg) {
// This method definition is only needed due to an MSVC oddity that
// instantiates the method despite it being unused. See crbug.com/v8/12266 .
UNREACHABLE();
}
IterationStatement* AsIterationStatement(BreakableStatement* s) {
return s->AsIterationStatement();
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment