Commit 252eb705 authored by jarin's avatar jarin Committed by Commit bot

Ignore generic IC state count for Ignition->Turbo tier up decision.

We benefit from the optimizing compiler even if the IC state is generic,
so we'd better ignore the generic IC state count for the optimization
decision. This improves our speedometer score from 61.5 to 63.7
(default configuration is 65.9).

Review-Url: https://codereview.chromium.org/2674203002
Cr-Commit-Position: refs/heads/master@{#42955}
parent b69b24a2
...@@ -408,8 +408,7 @@ OptimizationReason RuntimeProfiler::ShouldOptimizeIgnition( ...@@ -408,8 +408,7 @@ OptimizationReason RuntimeProfiler::ShouldOptimizeIgnition(
int typeinfo, generic, total, type_percentage, generic_percentage; int typeinfo, generic, total, type_percentage, generic_percentage;
GetICCounts(function, &typeinfo, &generic, &total, &type_percentage, GetICCounts(function, &typeinfo, &generic, &total, &type_percentage,
&generic_percentage); &generic_percentage);
if (type_percentage >= FLAG_type_info_threshold && if (type_percentage >= FLAG_type_info_threshold) {
generic_percentage <= FLAG_generic_ic_threshold) {
// If this particular function hasn't had any ICs patched for enough // If this particular function hasn't had any ICs patched for enough
// ticks, optimize it now. // ticks, optimize it now.
return OptimizationReason::kHotAndStable; return OptimizationReason::kHotAndStable;
...@@ -431,8 +430,7 @@ OptimizationReason RuntimeProfiler::ShouldOptimizeIgnition( ...@@ -431,8 +430,7 @@ OptimizationReason RuntimeProfiler::ShouldOptimizeIgnition(
int typeinfo, generic, total, type_percentage, generic_percentage; int typeinfo, generic, total, type_percentage, generic_percentage;
GetICCounts(function, &typeinfo, &generic, &total, &type_percentage, GetICCounts(function, &typeinfo, &generic, &total, &type_percentage,
&generic_percentage); &generic_percentage);
if (type_percentage >= FLAG_type_info_threshold && if (type_percentage >= FLAG_type_info_threshold) {
generic_percentage <= FLAG_generic_ic_threshold) {
return OptimizationReason::kSmallFunction; return OptimizationReason::kSmallFunction;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment