Commit 21c74f4f authored by Junliang Yan's avatar Junliang Yan Committed by Commit Bot

[fastcall] Store full size pointer to template data

This fixes an issue on 64-bit big endian architectures as discussed in
https://chromium-review.googlesource.com/c/v8/v8/+/2603925, where stack
slots always have the system pointer size, even with pointer compression
enabled.

Bug: chromium:1052746
Change-Id: I84030ba8bcde71cb1768bd7286314cf09c4dc640
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2645721Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Junliang Yan <junyan@redhat.com>
Cr-Commit-Position: refs/heads/master@{#72294}
parent b6ba1054
...@@ -5014,7 +5014,7 @@ Node* EffectControlLinearizer::LowerFastApiCall(Node* node) { ...@@ -5014,7 +5014,7 @@ Node* EffectControlLinearizer::LowerFastApiCall(Node* node) {
fast_api_call_stack_slot_, fast_api_call_stack_slot_,
static_cast<int>(offsetof(v8::FastApiCallbackOptions, fallback)), static_cast<int>(offsetof(v8::FastApiCallbackOptions, fallback)),
jsgraph()->ZeroConstant()); jsgraph()->ZeroConstant());
__ Store(StoreRepresentation(MachineRepresentation::kTaggedPointer, __ Store(StoreRepresentation(MachineType::PointerRepresentation(),
kNoWriteBarrier), kNoWriteBarrier),
fast_api_call_stack_slot_, fast_api_call_stack_slot_,
static_cast<int>(offsetof(v8::FastApiCallbackOptions, data)), static_cast<int>(offsetof(v8::FastApiCallbackOptions, data)),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment