Commit 1e1cdca1 authored by Richard Wang's avatar Richard Wang Committed by V8 LUCI CQ

Update reclient version, allow mac to checkout reclient, add mac builder

Mac builder added per https://chromium-review.googlesource.com/c/v8/v8/+/3755921/comments/dc378d70_002b4107

Bump the re-client version to match the same one chromium is currently using: https://source.chromium.org/chromium/chromium/src/+/main:DEPS;l=265;drc=11428e8ebaf6a78020d442da479b5b0daa0dffb5

The older version of re-client 0.40.0.40ff5a5 will not work when attempting to use it in a recipe targeting mac

The version bump has been tested successfully with V8 Official Linux64 (reclient) https://ci.chromium.org/raw/build/logs.chromium.org/v8/led/richardwa_google.com/dd361303d10e4d506bd31e16ca73bdef6183e622f55493f90d9c152195c5c4fc/+/build.proto?server=chromium-swarm.appspot.com and V8 Linux64 - builder (reclient) https://ci.chromium.org/raw/build/logs.chromium.org/v8/led/richardwa_google.com/758cd57ad9ee572bcfe339a2435eb82e1028e72bf74a7b57cabfd616ffad1e28/+/build.proto?server=chromium-swarm.appspot.com

Bug: b:238283947
Change-Id: I88e306f930c030173813b591e63a363da2d47cf1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3752430Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Richard Wang <richardwa@google.com>
Cr-Commit-Position: refs/heads/main@{#81656}
parent c3e0ad47
...@@ -40,7 +40,7 @@ vars = { ...@@ -40,7 +40,7 @@ vars = {
'fuchsia_sdk_cipd_prefix': 'fuchsia/sdk/gn/', 'fuchsia_sdk_cipd_prefix': 'fuchsia/sdk/gn/',
# reclient CIPD package version # reclient CIPD package version
'reclient_version': 're_client_version:0.40.0.40ff5a5', 'reclient_version': 're_client_version:0.69.0.458df98-gomaip',
# GN CIPD package version. # GN CIPD package version.
'gn_version': 'git_revision:9ef321772ecc161937db69acb346397e0ccc484d', 'gn_version': 'git_revision:9ef321772ecc161937db69acb346397e0ccc484d',
...@@ -140,7 +140,7 @@ deps = { ...@@ -140,7 +140,7 @@ deps = {
} }
], ],
'dep_type': 'cipd', 'dep_type': 'cipd',
'condition': '(host_os == "linux" or host_os == "win") and checkout_reclient', 'condition': '(host_os == "linux" or host_os == "mac" or host_os == "win") and checkout_reclient',
}, },
'test/benchmarks/data': 'test/benchmarks/data':
Var('chromium_url') + '/v8/deps/third_party/benchmarks.git' + '@' + '05d7188267b4560491ff9155c5ee13e207ecd65f', Var('chromium_url') + '/v8/deps/third_party/benchmarks.git' + '@' + '05d7188267b4560491ff9155c5ee13e207ecd65f',
......
...@@ -90,6 +90,7 @@ ...@@ -90,6 +90,7 @@
# Mac. # Mac.
'V8 Mac64 - builder': 'release_x64', 'V8 Mac64 - builder': 'release_x64',
'V8 Mac64 - debug builder': 'debug_x64', 'V8 Mac64 - debug builder': 'debug_x64',
'V8 Mac64 - builder (reclient)': 'release_x64_reclient',
'V8 Official Mac ARM64': 'release_arm64', 'V8 Official Mac ARM64': 'release_arm64',
'V8 Official Mac ARM64 Debug': 'debug_arm64', 'V8 Official Mac ARM64 Debug': 'debug_arm64',
'V8 Mac64 ASAN - builder': 'release_x64_asan_no_lsan', 'V8 Mac64 ASAN - builder': 'release_x64_asan_no_lsan',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment