Commit 1cac58d5 authored by Ulan Degenbaev's avatar Ulan Degenbaev Committed by Commit Bot

[test] Fix flaky unittests/RuntimeCallStatsTest.GarbageCollection

The test fails because of the race condition between concurrent GC
threads and the destructor of the test.

Bug: v8:11413
Change-Id: I5a138a61c16ddf2398e7c54defe6cc4008ca3330
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2839552Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74065}
parent 5540fbfc
...@@ -24,9 +24,6 @@ ...@@ -24,9 +24,6 @@
# The initial CL only fixed the crash. The test still causes an endless # The initial CL only fixed the crash. The test still causes an endless
# loop instead of properly reporting a RangeError for a stack overflow. # loop instead of properly reporting a RangeError for a stack overflow.
'regress/regress-crbug-1080638': [SKIP], 'regress/regress-crbug-1080638': [SKIP],
# https://crbug.com/v8/11338
'runtime-call-stats/enable-disable': [PASS, ['verify_csa', SKIP]],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
...@@ -623,6 +623,10 @@ TEST_F(RuntimeCallStatsTest, ApiGetter) { ...@@ -623,6 +623,10 @@ TEST_F(RuntimeCallStatsTest, ApiGetter) {
TEST_F(RuntimeCallStatsTest, GarbageCollection) { TEST_F(RuntimeCallStatsTest, GarbageCollection) {
FLAG_expose_gc = true; FLAG_expose_gc = true;
// Disable concurrent GC threads because otherwise they may continue
// running after this test completes and race with is_runtime_stats_enabled()
// updates.
FLAG_single_threaded_gc = true;
v8::Isolate* isolate = v8_isolate(); v8::Isolate* isolate = v8_isolate();
RunJS( RunJS(
"let root = [];" "let root = [];"
......
...@@ -3,12 +3,6 @@ ...@@ -3,12 +3,6 @@
# found in the LICENSE file. # found in the LICENSE file.
[ [
##############################################################################
[ALWAYS, {
# https://crbug.com/v8/11413
'RuntimeCallStatsTest.GarbageCollection': [PASS, ['verify_csa', SKIP]],
}], # ALWAYS
############################################################################## ##############################################################################
['system == macos and asan', { ['system == macos and asan', {
# BUG(820416). # BUG(820416).
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment