Commit 1a0cc926 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

[tools] return early in fetch_deps.py.

TBR=machenbach@chromium.org

Bug: v8:6105
Change-Id: I15fe26c8546e024794c165affd17ce104ecae4a1
Reviewed-on: https://chromium-review.googlesource.com/867870Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50616}
parent d53c4aa0
...@@ -61,6 +61,12 @@ def EnsureGit(v8_path): ...@@ -61,6 +61,12 @@ def EnsureGit(v8_path):
return True return True
def FetchDeps(v8_path): def FetchDeps(v8_path):
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
# Verify path. # Verify path.
v8_path = os.path.abspath(v8_path) v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path) assert os.path.isdir(v8_path)
...@@ -89,11 +95,6 @@ def FetchDeps(v8_path): ...@@ -89,11 +95,6 @@ def FetchDeps(v8_path):
if os.path.isfile(gclient_entries): if os.path.isfile(gclient_entries):
os.remove(gclient_entries) os.remove(gclient_entries)
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
if __name__ == "__main__": if __name__ == "__main__":
FetchDeps(sys.argv[1]) FetchDeps(sys.argv[1])
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment