Commit 13a96f93 authored by Andreas Haas's avatar Andreas Haas Committed by V8 LUCI CQ

[wasm] Trigger FinishedCompilationChunk event only with dynamic tiering

R=clemensb@chromium.org

Bug: v8:12281
Change-Id: Ice1465c2656c0ffd95b6297039f40762a176ddb4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211581Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77282}
parent 1860b816
...@@ -755,7 +755,7 @@ class CompilationStateImpl { ...@@ -755,7 +755,7 @@ class CompilationStateImpl {
int outstanding_top_tier_functions_ = 0; int outstanding_top_tier_functions_ = 0;
// The amount of generated top tier code since the last // The amount of generated top tier code since the last
// {kFinishedCompilationChunk} event. // {kFinishedCompilationChunk} event.
size_t bytes_since_last_chunk = 0; size_t bytes_since_last_chunk_ = 0;
std::vector<uint8_t> compilation_progress_; std::vector<uint8_t> compilation_progress_;
int outstanding_recompilation_functions_ = 0; int outstanding_recompilation_functions_ = 0;
...@@ -3331,7 +3331,7 @@ void CompilationStateImpl::OnFinishedUnits( ...@@ -3331,7 +3331,7 @@ void CompilationStateImpl::OnFinishedUnits(
outstanding_baseline_units_--; outstanding_baseline_units_--;
} }
if (code->tier() == ExecutionTier::kTurbofan) { if (code->tier() == ExecutionTier::kTurbofan) {
bytes_since_last_chunk += code->instructions().size(); bytes_since_last_chunk_ += code->instructions().size();
} }
if (reached_tier < required_top_tier && if (reached_tier < required_top_tier &&
required_top_tier <= code->tier()) { required_top_tier <= code->tier()) {
...@@ -3393,10 +3393,11 @@ void CompilationStateImpl::TriggerCallbacks( ...@@ -3393,10 +3393,11 @@ void CompilationStateImpl::TriggerCallbacks(
} }
} }
if (static_cast<size_t>(FLAG_wasm_caching_threshold) < if (dynamic_tiering_ == DynamicTiering::kEnabled &&
bytes_since_last_chunk) { static_cast<size_t>(FLAG_wasm_caching_threshold) <
bytes_since_last_chunk_) {
triggered_events.Add(CompilationEvent::kFinishedCompilationChunk); triggered_events.Add(CompilationEvent::kFinishedCompilationChunk);
bytes_since_last_chunk = 0; bytes_since_last_chunk_ = 0;
} }
if (compile_failed_.load(std::memory_order_relaxed)) { if (compile_failed_.load(std::memory_order_relaxed)) {
// *Only* trigger the "failed" event. // *Only* trigger the "failed" event.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment