Commit 1243ce0b authored by hpayer's avatar hpayer Committed by Commit bot

[heap] Clean-up incrementally finalize marking.

Review URL: https://codereview.chromium.org/1424233002

Cr-Commit-Position: refs/heads/master@{#31639}
parent 4cd3c169
...@@ -776,7 +776,7 @@ void Heap::HandleGCRequest() { ...@@ -776,7 +776,7 @@ void Heap::HandleGCRequest() {
} }
DCHECK(FLAG_finalize_marking_incrementally); DCHECK(FLAG_finalize_marking_incrementally);
if (!incremental_marking()->finalize_marking_completed()) { if (!incremental_marking()->finalize_marking_completed()) {
FinalizeIncrementalMarking("GC interrupt"); FinalizeIncrementalMarking("GC interrupt: finalize incremental marking");
} }
} }
...@@ -788,8 +788,7 @@ void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) { ...@@ -788,8 +788,7 @@ void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) {
void Heap::FinalizeIncrementalMarking(const char* gc_reason) { void Heap::FinalizeIncrementalMarking(const char* gc_reason) {
if (FLAG_trace_incremental_marking) { if (FLAG_trace_incremental_marking) {
PrintF("[IncrementalMarking] Overapproximate weak closure (%s).\n", PrintF("[IncrementalMarking] (%s).\n", gc_reason);
gc_reason);
} }
GCTracer::Scope gc_scope(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE); GCTracer::Scope gc_scope(tracer(), GCTracer::Scope::MC_INCREMENTAL_FINALIZE);
...@@ -4095,7 +4094,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) { ...@@ -4095,7 +4094,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) {
gc_idle_time_handler_->ShouldDoOverApproximateWeakClosure( gc_idle_time_handler_->ShouldDoOverApproximateWeakClosure(
static_cast<size_t>(idle_time_in_ms))))) { static_cast<size_t>(idle_time_in_ms))))) {
FinalizeIncrementalMarking( FinalizeIncrementalMarking(
"Idle notification: overapproximate weak closure"); "Idle notification: finalize incremental marking");
return true; return true;
} else if (incremental_marking()->IsComplete() || } else if (incremental_marking()->IsComplete() ||
(mark_compact_collector()->marking_deque()->IsEmpty() && (mark_compact_collector()->marking_deque()->IsEmpty() &&
...@@ -4103,7 +4102,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) { ...@@ -4103,7 +4102,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(double idle_time_in_ms) {
static_cast<size_t>(idle_time_in_ms), size_of_objects, static_cast<size_t>(idle_time_in_ms), size_of_objects,
final_incremental_mark_compact_speed_in_bytes_per_ms))) { final_incremental_mark_compact_speed_in_bytes_per_ms))) {
CollectAllGarbage(current_gc_flags_, CollectAllGarbage(current_gc_flags_,
"idle notification: finalize incremental"); "idle notification: finalize incremental marking");
return true; return true;
} }
return false; return false;
......
...@@ -664,8 +664,7 @@ void IncrementalMarking::FinalizeIncrementally() { ...@@ -664,8 +664,7 @@ void IncrementalMarking::FinalizeIncrementally() {
int marking_progress = int marking_progress =
abs(old_marking_deque_top - abs(old_marking_deque_top -
heap_->mark_compact_collector()->marking_deque()->top()) / heap_->mark_compact_collector()->marking_deque()->top());
kPointerSize;
++incremental_marking_finalization_rounds_; ++incremental_marking_finalization_rounds_;
if ((incremental_marking_finalization_rounds_ >= if ((incremental_marking_finalization_rounds_ >=
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment