Commit 111cbd98 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by Commit Bot

[compiler] Move instance_descriptors synchronized setter to private

In a previous CL (crrev.com/c/v8/v8/+/2424130/17/src/objects/map.h) I
moved it to public to use the parent macro. Move it back to private
since it does not need to be public.

Bug: v8:7790
Change-Id: I5fd78a8fcef2bd454585b6dc428c1b1d2bb62422
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454715
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70377}
parent 7c4cc5ed
...@@ -595,7 +595,7 @@ class Map : public HeapObject { ...@@ -595,7 +595,7 @@ class Map : public HeapObject {
// [instance descriptors]: describes the object. // [instance descriptors]: describes the object.
DECL_RELAXED_ACCESSORS(instance_descriptors, DescriptorArray) DECL_RELAXED_ACCESSORS(instance_descriptors, DescriptorArray)
DECL_RELEASE_ACQUIRE_ACCESSORS(instance_descriptors, DescriptorArray) DECL_ACQUIRE_GETTER(instance_descriptors, DescriptorArray)
V8_EXPORT_PRIVATE void SetInstanceDescriptors(Isolate* isolate, V8_EXPORT_PRIVATE void SetInstanceDescriptors(Isolate* isolate,
DescriptorArray descriptors, DescriptorArray descriptors,
int number_of_own_descriptors); int number_of_own_descriptors);
...@@ -975,6 +975,9 @@ class Map : public HeapObject { ...@@ -975,6 +975,9 @@ class Map : public HeapObject {
MaybeHandle<Object> old_value, MaybeHandle<FieldType> new_field_type, MaybeHandle<Object> old_value, MaybeHandle<FieldType> new_field_type,
MaybeHandle<Object> new_value); MaybeHandle<Object> new_value);
// Use the high-level instance_descriptors/SetInstanceDescriptors instead.
DECL_RELEASE_SETTER(instance_descriptors, DescriptorArray)
static const int kFastPropertiesSoftLimit = 12; static const int kFastPropertiesSoftLimit = 12;
static const int kMaxFastProperties = 128; static const int kMaxFastProperties = 128;
......
...@@ -104,14 +104,26 @@ ...@@ -104,14 +104,26 @@
inline void set_##name(type value, tag_type, \ inline void set_##name(type value, tag_type, \
WriteBarrierMode mode = UPDATE_WRITE_BARRIER); WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
#define DECL_RELAXED_ACCESSORS(name, type) \ #define DECL_RELAXED_GETTER(name, type) \
DECL_ACCESSORS_LOAD_TAG(name, type, RelaxedLoadTag) \ DECL_ACCESSORS_LOAD_TAG(name, type, RelaxedLoadTag)
#define DECL_RELAXED_SETTER(name, type) \
DECL_ACCESSORS_STORE_TAG(name, type, RelaxedStoreTag) DECL_ACCESSORS_STORE_TAG(name, type, RelaxedStoreTag)
#define DECL_RELEASE_ACQUIRE_ACCESSORS(name, type) \ #define DECL_RELAXED_ACCESSORS(name, type) \
DECL_ACCESSORS_LOAD_TAG(name, type, AcquireLoadTag) \ DECL_RELAXED_GETTER(name, type) \
DECL_RELAXED_SETTER(name, type)
#define DECL_ACQUIRE_GETTER(name, type) \
DECL_ACCESSORS_LOAD_TAG(name, type, AcquireLoadTag)
#define DECL_RELEASE_SETTER(name, type) \
DECL_ACCESSORS_STORE_TAG(name, type, ReleaseStoreTag) DECL_ACCESSORS_STORE_TAG(name, type, ReleaseStoreTag)
#define DECL_RELEASE_ACQUIRE_ACCESSORS(name, type) \
DECL_ACQUIRE_GETTER(name, type) \
DECL_RELEASE_SETTER(name, type)
#define DECL_CAST(Type) \ #define DECL_CAST(Type) \
V8_INLINE static Type cast(Object object); \ V8_INLINE static Type cast(Object object); \
V8_INLINE static Type unchecked_cast(Object object) { \ V8_INLINE static Type unchecked_cast(Object object) { \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment