Commit 0d0c9107 authored by Tobias Tebbi's avatar Tobias Tebbi Committed by Commit Bot

[torque] do not generate field offsets for internal classes

Bug: v8:7793
Change-Id: I503622356746acbeaaeca88ce5bacf7ab9c93ab8
Reviewed-on: https://chromium-review.googlesource.com/c/1491215Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59890}
parent 5c05165d
......@@ -2654,6 +2654,9 @@ void ImplementationVisitor::GenerateClassDefinitions(std::string& file_name) {
"\n\n";
for (auto i : GlobalContext::GetClasses()) {
ClassType* type = i.second;
if (!type->IsExtern()) continue;
// TODO(danno): Ideally (and we've got several core V8 dev's feedback
// supporting this), Torque should generate the constants for the offsets
// directly and not go through the existing layer of macros, which actually
......@@ -2662,7 +2665,6 @@ void ImplementationVisitor::GenerateClassDefinitions(std::string& file_name) {
new_contents_stream << "#define ";
new_contents_stream << CapifyStringWithUnderscores(i.first)
<< "_FIELDS(V) \\\n";
ClassType* type = i.second;
std::vector<Field> fields = type->fields();
FieldSectionType section = FieldSectionType::kNoSection;
std::set<FieldSectionType> completed_sections;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment