Remove grab-bag includes of v8.h from IC subsystem.

R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1293793002 Cr-Commit-Position: refs/heads/master@{#30178}

Remove grab-bag includes of v8.h from IC subsystem.
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1293793002 Cr-Commit-Position: refs/heads/master@{#30178}
0c5fbd39 · mstarzinger · Commit bot · c7ba2f7f · 0c5fbd39 · 0c5fbd39
Commit 0c5fbd39 authored Aug 14, 2015 by mstarzinger Committed by Commit bot Aug 14, 2015
49 changed files
--- a/src/arm/constants-arm.h
+++ b/src/arm/constants-arm.h
@@ -5,6 +5,12 @@
 #ifndef V8_ARM_CONSTANTS_ARM_H_
 #define V8_ARM_CONSTANTS_ARM_H_

+#include <stdint.h>
+
+#include "src/base/logging.h"
+#include "src/base/macros.h"
+#include "src/globals.h"
+
 // ARM EABI is required.
 #if defined(__arm__) && !defined(__ARM_EABI__)
 #error ARM EABI support is required.

--- a/src/ic/access-compiler.cc
+++ b/src/ic/access-compiler.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #include "src/ic/access-compiler.h"



--- a/src/ic/arm/access-compiler-arm.cc
+++ b/src/ic/arm/access-compiler-arm.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM

 #include "src/ic/access-compiler.h"

--- a/src/ic/arm/handler-compiler-arm.cc
+++ b/src/ic/arm/handler-compiler-arm.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM

 #include "src/ic/call-optimization.h"

--- a/src/ic/arm/ic-arm.cc
+++ b/src/ic/arm/ic-arm.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM

 #include "src/codegen.h"

--- a/src/ic/arm/ic-compiler-arm.cc
+++ b/src/ic/arm/ic-compiler-arm.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM

 #include "src/ic/ic.h"

--- a/src/ic/arm/stub-cache-arm.cc
+++ b/src/ic/arm/stub-cache-arm.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM

 #include "src/codegen.h"

--- a/src/ic/arm64/access-compiler-arm64.cc
+++ b/src/ic/arm64/access-compiler-arm64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM64

 #include "src/ic/access-compiler.h"

--- a/src/ic/arm64/handler-compiler-arm64.cc
+++ b/src/ic/arm64/handler-compiler-arm64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM64

 #include "src/ic/call-optimization.h"

--- a/src/ic/arm64/ic-arm64.cc
+++ b/src/ic/arm64/ic-arm64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM64

 #include "src/codegen.h"

--- a/src/ic/arm64/ic-compiler-arm64.cc
+++ b/src/ic/arm64/ic-compiler-arm64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM64

 #include "src/ic/ic.h"

--- a/src/ic/arm64/stub-cache-arm64.cc
+++ b/src/ic/arm64/stub-cache-arm64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_ARM64

 #include "src/codegen.h"

--- a/src/ic/call-optimization.cc
+++ b/src/ic/call-optimization.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #include "src/ic/call-optimization.h"



--- a/src/ic/handler-compiler.cc
+++ b/src/ic/handler-compiler.cc
@@ -2,11 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
+#include "src/ic/handler-compiler.h"

 #include "src/cpu-profiler.h"
 #include "src/ic/call-optimization.h"
-#include "src/ic/handler-compiler.h"
 #include "src/ic/ic.h"
 #include "src/ic/ic-inl.h"


--- a/src/ic/ia32/access-compiler-ia32.cc
+++ b/src/ic/ia32/access-compiler-ia32.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_IA32

 #include "src/ic/access-compiler.h"

--- a/src/ic/ia32/handler-compiler-ia32.cc
+++ b/src/ic/ia32/handler-compiler-ia32.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_IA32

 #include "src/ic/call-optimization.h"

--- a/src/ic/ia32/ic-compiler-ia32.cc
+++ b/src/ic/ia32/ic-compiler-ia32.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_IA32

 #include "src/ic/ic.h"

--- a/src/ic/ia32/ic-ia32.cc
+++ b/src/ic/ia32/ic-ia32.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_IA32

 #include "src/codegen.h"

--- a/src/ic/ia32/stub-cache-ia32.cc
+++ b/src/ic/ia32/stub-cache-ia32.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_IA32

 #include "src/codegen.h"

--- a/src/ic/ic-compiler.cc
+++ b/src/ic/ic-compiler.cc
@@ -2,12 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
+#include "src/ic/ic-compiler.h"

 #include "src/cpu-profiler.h"
 #include "src/ic/handler-compiler.h"
 #include "src/ic/ic-inl.h"
-#include "src/ic/ic-compiler.h"


 namespace v8 {

--- a/src/ic/ic-state.cc
+++ b/src/ic/ic-state.cc
@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
+#include "src/ic/ic-state.h"

 #include "src/ic/ic.h"
-#include "src/ic/ic-state.h"

 namespace v8 {
 namespace internal {

--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
+#include "src/ic/ic.h"

 #include "src/accessors.h"
 #include "src/api.h"

--- a/src/ic/mips/access-compiler-mips.cc
+++ b/src/ic/mips/access-compiler-mips.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS

 #include "src/ic/access-compiler.h"

--- a/src/ic/mips/handler-compiler-mips.cc
+++ b/src/ic/mips/handler-compiler-mips.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS

 #include "src/ic/call-optimization.h"

--- a/src/ic/mips/ic-compiler-mips.cc
+++ b/src/ic/mips/ic-compiler-mips.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS

 #include "src/ic/ic.h"

--- a/src/ic/mips/ic-mips.cc
+++ b/src/ic/mips/ic-mips.cc
@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-
-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS

 #include "src/codegen.h"

--- a/src/ic/mips/stub-cache-mips.cc
+++ b/src/ic/mips/stub-cache-mips.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS

 #include "src/codegen.h"

--- a/src/ic/mips64/access-compiler-mips64.cc
+++ b/src/ic/mips64/access-compiler-mips64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS64

 #include "src/ic/access-compiler.h"

--- a/src/ic/mips64/handler-compiler-mips64.cc
+++ b/src/ic/mips64/handler-compiler-mips64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS64

 #include "src/ic/call-optimization.h"

--- a/src/ic/mips64/ic-compiler-mips64.cc
+++ b/src/ic/mips64/ic-compiler-mips64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS64

 #include "src/ic/ic.h"

--- a/src/ic/mips64/ic-mips64.cc
+++ b/src/ic/mips64/ic-mips64.cc
@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-
-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS64

 #include "src/codegen.h"

--- a/src/ic/mips64/stub-cache-mips64.cc
+++ b/src/ic/mips64/stub-cache-mips64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_MIPS64

 #include "src/codegen.h"

--- a/src/ic/ppc/access-compiler-ppc.cc
+++ b/src/ic/ppc/access-compiler-ppc.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_PPC

 #include "src/ic/access-compiler.h"

--- a/src/ic/ppc/handler-compiler-ppc.cc
+++ b/src/ic/ppc/handler-compiler-ppc.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_PPC

 #include "src/ic/call-optimization.h"

--- a/src/ic/ppc/ic-compiler-ppc.cc
+++ b/src/ic/ppc/ic-compiler-ppc.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_PPC

 #include "src/ic/ic.h"

--- a/src/ic/ppc/ic-ppc.cc
+++ b/src/ic/ppc/ic-ppc.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_PPC

 #include "src/codegen.h"

--- a/src/ic/ppc/stub-cache-ppc.cc
+++ b/src/ic/ppc/stub-cache-ppc.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_PPC

 #include "src/codegen.h"

--- a/src/ic/stub-cache.cc
+++ b/src/ic/stub-cache.cc
@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
+#include "src/ic/stub-cache.h"

 #include "src/base/bits.h"
-#include "src/ic/stub-cache.h"
 #include "src/type-info.h"

 namespace v8 {

--- a/src/ic/x64/access-compiler-x64.cc
+++ b/src/ic/x64/access-compiler-x64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X64

 #include "src/ic/access-compiler.h"

--- a/src/ic/x64/handler-compiler-x64.cc
+++ b/src/ic/x64/handler-compiler-x64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X64

 #include "src/ic/call-optimization.h"

--- a/src/ic/x64/ic-compiler-x64.cc
+++ b/src/ic/x64/ic-compiler-x64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X64

 #include "src/ic/ic.h"

--- a/src/ic/x64/ic-x64.cc
+++ b/src/ic/x64/ic-x64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X64

 #include "src/codegen.h"

--- a/src/ic/x64/stub-cache-x64.cc
+++ b/src/ic/x64/stub-cache-x64.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X64

 #include "src/codegen.h"

--- a/src/ic/x87/access-compiler-x87.cc
+++ b/src/ic/x87/access-compiler-x87.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X87

 #include "src/ic/access-compiler.h"

--- a/src/ic/x87/handler-compiler-x87.cc
+++ b/src/ic/x87/handler-compiler-x87.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X87

 #include "src/ic/call-optimization.h"

--- a/src/ic/x87/ic-compiler-x87.cc
+++ b/src/ic/x87/ic-compiler-x87.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X87

 #include "src/ic/ic.h"

--- a/src/ic/x87/ic-x87.cc
+++ b/src/ic/x87/ic-x87.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X87

 #include "src/codegen.h"

--- a/src/ic/x87/stub-cache-x87.cc
+++ b/src/ic/x87/stub-cache-x87.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "src/v8.h"
-
 #if V8_TARGET_ARCH_X87

 #include "src/codegen.h"

--- a/src/mips64/constants-mips64.h
+++ b/src/mips64/constants-mips64.h
@@ -5,6 +5,10 @@
 #ifndef  V8_MIPS_CONSTANTS_H_
 #define  V8_MIPS_CONSTANTS_H_

+#include "src/base/logging.h"
+#include "src/base/macros.h"
+#include "src/globals.h"
+
 // UNIMPLEMENTED_ macro for MIPS.
 #ifdef DEBUG
 #define UNIMPLEMENTED_MIPS()                                                  \