Commit 0a3b7739 authored by machenbach's avatar machenbach Committed by Commit bot

Prepare for using ninja for win64.

BUG=chromium:508921
LOG=n

Review URL: https://codereview.chromium.org/1234443003

Cr-Commit-Position: refs/heads/master@{#29605}
parent d02f6248
...@@ -358,6 +358,19 @@ ...@@ -358,6 +358,19 @@
'Release': { 'Release': {
'cflags+': ['<@(release_extra_cflags)'], 'cflags+': ['<@(release_extra_cflags)'],
}, },
'conditions': [
['OS=="win"', {
'Optdebug_x64': {
'inherit_from': ['Optdebug'],
},
'Debug_x64': {
'inherit_from': ['Debug'],
},
'Release_x64': {
'inherit_from': ['Release'],
},
}],
],
}, },
'conditions':[ 'conditions':[
['(clang==1 or host_clang==1) and OS!="win"', { ['(clang==1 or host_clang==1) and OS!="win"', {
......
...@@ -322,6 +322,15 @@ def RandomSeed(): ...@@ -322,6 +322,15 @@ def RandomSeed():
return seed return seed
def BuildbotToV8Mode(config):
"""Convert buildbot build configs to configs understood by the v8 runner.
V8 configs are always lower case and without the additional _x64 suffix for
64 bit builds on windows with ninja.
"""
mode = config[:-4] if config.endswith('_x64') else config
return mode.lower()
def ProcessOptions(options): def ProcessOptions(options):
global VARIANT_FLAGS global VARIANT_FLAGS
global VARIANTS global VARIANTS
...@@ -334,7 +343,7 @@ def ProcessOptions(options): ...@@ -334,7 +343,7 @@ def ProcessOptions(options):
options.mode = ",".join([tokens[1] for tokens in options.arch_and_mode]) options.mode = ",".join([tokens[1] for tokens in options.arch_and_mode])
options.mode = options.mode.split(",") options.mode = options.mode.split(",")
for mode in options.mode: for mode in options.mode:
if not mode.lower() in MODES: if not BuildbotToV8Mode(mode) in MODES:
print "Unknown mode %s" % mode print "Unknown mode %s" % mode
return False return False
if options.arch in ["auto", "native"]: if options.arch in ["auto", "native"]:
...@@ -531,7 +540,7 @@ def Execute(arch, mode, args, options, suites, workspace): ...@@ -531,7 +540,7 @@ def Execute(arch, mode, args, options, suites, workspace):
# TODO(machenbach): Get rid of different output folder location on # TODO(machenbach): Get rid of different output folder location on
# buildbot. Currently this is capitalized Release and Debug. # buildbot. Currently this is capitalized Release and Debug.
shell_dir = os.path.join(workspace, options.outdir, mode) shell_dir = os.path.join(workspace, options.outdir, mode)
mode = mode.lower() mode = BuildbotToV8Mode(mode)
else: else:
shell_dir = os.path.join( shell_dir = os.path.join(
workspace, workspace,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment