Commit 03202a38 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[csa] Expand comment on Reference struct

Change-Id: Iec5bf3e3fa238e4dce4ec89840cfd6c39a6726a9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568273Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71562}
parent 58477dc3
......@@ -1124,10 +1124,15 @@ class V8_EXPORT_PRIVATE CodeStubAssembler
Map::kConstructorOrBackPointerOrNativeContextOffset);
}
// Reference is the CSA-equivalent of a Torque reference value,
// representing an inner pointer into a HeapObject.
// The object can be a HeapObject or an all-zero bitpattern.
// TODO(gsps): Remove in favor of flattened {Load,Store}Reference interface
// Reference is the CSA-equivalent of a Torque reference value, representing
// an inner pointer into a HeapObject.
//
// The object can be a HeapObject or an all-zero bitpattern. The latter is
// used for off-heap data, in which case the offset holds the actual address
// and the data must be untagged (i.e. accessed via the Load-/StoreReference
// overloads for TNode<UntaggedT>-convertible types below).
//
// TODO(gsps): Remove in favor of flattened {Load,Store}Reference interface.
struct Reference {
TNode<Object> object;
TNode<IntPtrT> offset;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment