Skip to content

V
V8
Commit 010d43d2 authored by Al Muthanna Athamina's avatar Al Muthanna Athamina Committed by V8 LUCI CQ
Browse files
Options

[infra] Make no-fail the default for numfuzz builders 

Remove infra-staging from numfuzz builders and add
no-fail instead. Also remove the staging builders.

Bug: v8:11826
Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng
Change-Id: Icd7bc6275b5c78e38f0e75b5d133b3b7056f333e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182233
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77142}
parent 51ebc663
Hide whitespace changes
Inline Side-by-side
Showing with 25 additions and 185 deletions
infra/testing/builders.pyl
View file @ 010d43d2
...@@ -2048,136 +2048,15 @@ ...@@ -2048,136 +2048,15 @@
'suffix': 'threads', 'suffix': 'threads',
'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1']
}, },
{
'name': 'numfuzz',
'suffix': 'combined',
'test_args': [
'--total-timeout-sec=2100',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
'shards': 4
},
{
'name': 'numfuzz',
'suffix': 'scavenge',
'test_args': ['--total-timeout-sec=2100', '--stress-scavenge=1']
},
],
},
'V8 NumFuzz - debug': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{'name': 'd8testing_random_gc'},
{
'name': 'numfuzz',
'suffix': 'marking',
'test_args': ['--total-timeout-sec=2100', '--stress-marking=1'],
'shards': 2
},
{
'name': 'numfuzz',
'suffix': 'delay',
'test_args': ['--total-timeout-sec=2100', '--stress-delay-tasks=1']
},
{
'name': 'numfuzz',
'suffix': 'threads',
'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{
'name': 'numfuzz',
'suffix': 'combined',
'test_args': [
'--total-timeout-sec=2100',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
'shards': 3
},
{
'name': 'numfuzz',
'suffix': 'scavenge',
'test_args': ['--total-timeout-sec=2100', '--stress-scavenge=1']
},
{
'name': 'numfuzz',
'suffix': 'deopt',
'test_args': ['--total-timeout-sec=2100', '--stress-deopt=1'],
'shards': 2
},
],
},
'V8 NumFuzz - staging': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{
'name': 'numfuzz',
'suffix': 'deopt',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-deopt=1']
},
],
},
'V8 NumFuzz - TSAN - staging': {
'swarming_dimensions': {
'os': 'Ubuntu-18.04',
},
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [
{'name': 'd8testing_random_gc', 'shards': 2},
{
'name': 'numfuzz',
'suffix': 'marking',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-marking=1']
},
{
'name': 'numfuzz',
'suffix': 'delay',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-delay-tasks=1']
},
{
'name': 'numfuzz',
'suffix': 'threads',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-thread-pool-size=1']
},
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'stack', 'suffix': 'stack',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-stack-size=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-stack-size=1']
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined', 'suffix': 'combined',
'test_args': [ 'test_args': [
'--infra-staging',
'--total-timeout-sec=2100', '--total-timeout-sec=2100',
'--stress-delay-tasks=4', '--stress-delay-tasks=4',
'--stress-deopt=2', '--stress-deopt=2',
...@@ -2193,11 +2072,11 @@ ...@@ -2193,11 +2072,11 @@
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'scavenge', 'suffix': 'scavenge',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-scavenge=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-scavenge=1']
}, },
], ],
}, },
'V8 NumFuzz - debug - staging': { 'V8 NumFuzz - debug': {
'swarming_dimensions': { 'swarming_dimensions': {
'os': 'Ubuntu-18.04', 'os': 'Ubuntu-18.04',
}, },
...@@ -2211,29 +2090,28 @@ ...@@ -2211,29 +2090,28 @@
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'marking', 'suffix': 'marking',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-marking=1'], 'test_args': ['--total-timeout-sec=2100', '--stress-marking=1'],
'shards': 2 'shards': 2
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'delay', 'suffix': 'delay',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-delay-tasks=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-delay-tasks=1']
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'threads', 'suffix': 'threads',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-thread-pool-size=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-thread-pool-size=1']
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'stack', 'suffix': 'stack',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-stack-size=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-stack-size=1']
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined', 'suffix': 'combined',
'test_args': [ 'test_args': [
'--infra-staging',
'--total-timeout-sec=2100', '--total-timeout-sec=2100',
'--stress-delay-tasks=4', '--stress-delay-tasks=4',
'--stress-deopt=2', '--stress-deopt=2',
...@@ -2249,12 +2127,12 @@ ...@@ -2249,12 +2127,12 @@
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'scavenge', 'suffix': 'scavenge',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-scavenge=1'] 'test_args': ['--total-timeout-sec=2100', '--stress-scavenge=1']
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'deopt', 'suffix': 'deopt',
'test_args': ['--infra-staging', '--total-timeout-sec=2100', '--stress-deopt=1'], 'test_args': ['--total-timeout-sec=2100', '--stress-deopt=1'],
'shards': 2 'shards': 2
}, },
], ],
...@@ -2263,33 +2141,18 @@ ...@@ -2263,33 +2141,18 @@
'swarming_dimensions': { 'swarming_dimensions': {
'os': 'Ubuntu-18.04', 'os': 'Ubuntu-18.04',
}, },
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [ 'tests': [
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'deopt', 'suffix': 'deopt',
'test_args': ['--total-timeout-sec=900', '--stress-deopt=1'] 'test_args': ['--total-timeout-sec=900', '--stress-deopt=1']
}, },
{
'name': 'numfuzz',
'suffix': 'deopt-staging',
'test_args': ['--infra-staging', '--total-timeout-sec=900', '--stress-deopt=1']
},
], ],
}, },
'v8_numfuzz_tsan_ng_triggered': { 'v8_numfuzz_tsan_ng_triggered': {
'swarming_dimensions': { 'swarming_dimensions': {
'os': 'Ubuntu-18.04', 'os': 'Ubuntu-18.04',
}, },
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [ 'tests': [
{ {
'name': 'numfuzz', 'name': 'numfuzz',
...@@ -2308,23 +2171,13 @@ ...@@ -2308,23 +2171,13 @@
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined', 'suffix': 'stack',
'test_args': [ 'test_args': ['--total-timeout-sec=900', '--stress-stack-size=1']
'--total-timeout-sec=900',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined-staging', 'suffix': 'combined',
'test_args': [ 'test_args': [
'--infra-staging',
'--total-timeout-sec=900', '--total-timeout-sec=900',
'--stress-delay-tasks=4', '--stress-delay-tasks=4',
'--stress-deopt=2', '--stress-deopt=2',
...@@ -2333,6 +2186,7 @@ ...@@ -2333,6 +2186,7 @@
'--stress-marking=4', '--stress-marking=4',
'--stress-scavenge=4', '--stress-scavenge=4',
'--stress-thread-pool-size=2', '--stress-thread-pool-size=2',
'--stress-stack-size=1',
], ],
}, },
{ {
...@@ -2346,11 +2200,6 @@ ...@@ -2346,11 +2200,6 @@
'swarming_dimensions': { 'swarming_dimensions': {
'os': 'Ubuntu-18.04', 'os': 'Ubuntu-18.04',
}, },
'swarming_task_attrs': {
'expiration': 13800,
'hard_timeout': 4200,
'priority': 35,
},
'tests': [ 'tests': [
{'name': 'd8testing_random_gc'}, {'name': 'd8testing_random_gc'},
{ {
...@@ -2370,23 +2219,13 @@ ...@@ -2370,23 +2219,13 @@
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined', 'suffix': 'stack',
'test_args': [ 'test_args': ['--total-timeout-sec=900', '--stress-stack-size=1']
'--total-timeout-sec=900',
'--stress-delay-tasks=4',
'--stress-deopt=2',
'--stress-compaction=2',
'--stress-gc=4',
'--stress-marking=4',
'--stress-scavenge=4',
'--stress-thread-pool-size=2',
],
}, },
{ {
'name': 'numfuzz', 'name': 'numfuzz',
'suffix': 'combined-staging', 'suffix': 'combined',
'test_args': [ 'test_args': [
'--infra-staging',
'--total-timeout-sec=900', '--total-timeout-sec=900',
'--stress-delay-tasks=4', '--stress-delay-tasks=4',
'--stress-deopt=2', '--stress-deopt=2',
...@@ -2395,6 +2234,7 @@ ...@@ -2395,6 +2234,7 @@
'--stress-marking=4', '--stress-marking=4',
'--stress-scavenge=4', '--stress-scavenge=4',
'--stress-thread-pool-size=2', '--stress-thread-pool-size=2',
'--stress-stack-size=1',
], ],
}, },
{ {
......
tools/testrunner/num_fuzzer.py
View file @ 010d43d2
...@@ -124,9 +124,11 @@ class NumFuzzer(base_runner.BaseTestRunner): ...@@ -124,9 +124,11 @@ class NumFuzzer(base_runner.BaseTestRunner):
def _runner_flags(self): def _runner_flags(self):
"""Extra default flags specific to the test runner implementation.""" """Extra default flags specific to the test runner implementation."""
flags = ['--no-abort-on-contradictory-flags', '--testing-d8-test-runner'] flags = [
if self.infra_staging: '--no-abort-on-contradictory-flags',
flags.append('--no-fail') '--testing-d8-test-runner',
'--no-fail'
]
return flags return flags
def _get_statusfile_variables(self, options): def _get_statusfile_variables(self, options):
...@@ -163,7 +165,7 @@ class NumFuzzer(base_runner.BaseTestRunner): ...@@ -163,7 +165,7 @@ class NumFuzzer(base_runner.BaseTestRunner):
# TODO(majeski): Improve sharding when combiner is present. Maybe select # TODO(majeski): Improve sharding when combiner is present. Maybe select
# different random seeds for shards instead of splitting tests. # different random seeds for shards instead of splitting tests.
self._create_shard_proc(options), self._create_shard_proc(options),
ExpectationProc(self.infra_staging), ExpectationProc(),
combiner, combiner,
self._create_fuzzer(fuzzer_rng, options), self._create_fuzzer(fuzzer_rng, options),
sigproc, sigproc,
......
tools/testrunner/testproc/expectation.py
View file @ 010d43d2
...@@ -9,15 +9,13 @@ from testrunner.outproc import base as outproc ...@@ -9,15 +9,13 @@ from testrunner.outproc import base as outproc
class ExpectationProc(base.TestProcProducer): class ExpectationProc(base.TestProcProducer):
"""Test processor passing tests and results through and forgiving timeouts.""" """Test processor passing tests and results through and forgiving timeouts."""
def __init__(self, infra_staging): def __init__(self):
super(ExpectationProc, self).__init__('no-timeout') super(ExpectationProc, self).__init__('no-timeout')
self.infra_staging = infra_staging
def _next_test(self, test): def _next_test(self, test):
subtest = self._create_subtest(test, 'no_timeout') subtest = self._create_subtest(test, 'no_timeout')
subtest.allow_timeouts() subtest.allow_timeouts()
if self.infra_staging: subtest.allow_pass()
subtest.allow_pass()
return self._send_test(subtest) return self._send_test(subtest)
def _result_for(self, test, subtest, result): def _result_for(self, test, subtest, result):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment