• Mythri Alle's avatar
    Revert "[sparkplug] Support bytecode / baseline code flushing with sparkplug" · a079f057
    Mythri Alle authored
    This reverts commit ea55438a.
    
    Reason for revert: Likely culprit for these failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20NumFuzz/15494/overview
    
    Original change's description:
    > [sparkplug] Support bytecode / baseline code flushing with sparkplug
    >
    > Currently with sparkplug we don't flush bytecode / baseline code of
    > functions that were tiered up to sparkplug. This CL adds the support to
    > flush baseline code / bytecode of functions that have baseline code too.
    > This CL:
    > 1. Updates the BodyDescriptor of JSFunction to treat the Code field of
    > JSFunction as a custom weak pointer where the code is treated as weak if
    > the bytecode corresponding to this function is old.
    > 2. Updates GC to handle the functions that had a weak code object during
    > the atomic phase of GC.
    > 3. Updates the check for old bytecode to also consider when there is
    > baseline code on the function.
    >
    > This CL doesn't change any heuristics for flushing. The baseline code
    > will be flushed at the same time as bytecode.
    >
    > Change-Id: I6b51e06ebadb917b9f4b0f43f2afebd7f64cd26a
    > Bug: v8:11947
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992715
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75674}
    
    Bug: v8:11947
    Change-Id: I50535b9a6c6fc39eceb4f6c0e0c84c55bb92f30a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3017811Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75679}
    a079f057
js-function.cc 43.2 KB