• Seth Brenith's avatar
    Revert "[regalloc] Loop-top values can be backedges too" · fc2f7021
    Seth Brenith authored
    This reverts commit abb7cdc9.
    
    Reason for revert: regressions in jetstream2/gaussian-blur_sum
    
    Original change's description:
    > [regalloc] Loop-top values can be backedges too
    > 
    > When counting which backedges conflict with a loop-top phi value, we
    > should include values introduced at the start of the loop.
    > 
    > I don't expect this change to make performance differences on its own,
    > but it is a step toward changing the heuristic so that we're less likely
    > to introduce unnecessary load/store pairs across the backedge.
    > 
    > Bug: v8:10606
    > Change-Id: I299e388b0b964573119ba0b775d50f398c467c46
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2385715
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#69752}
    
    TBR=sigurds@chromium.org,yolanda.chen@intel.com,seth.brenith@microsoft.com,thibaudm@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:10606, chromium:1126663
    Change-Id: Idde0b7c89f2376ae016e834fa37c38f3d9eb5c1e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2404020Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#69824}
    fc2f7021
register-allocator.cc 204 KB