• Andreas Haas's avatar
    [wasm] Add instance to DebugBreak safepoint · 835a8b7d
    Andreas Haas authored
    Since recently, the WebAssembly instance gets cached in Liftoff code
    to avoid reloading it from the stack whenever it is used. Typically the
    cached instance gets invalidated at a function call and therefore does
    not need to be recorded in safepoints.
    
    However, when the DebugBreak builtin is called, the cached instance
    was not invalidated. It is even incorrect to invalidate the cached
    instance there because that would modify the CacheState of Liftoff.
    Therefore this CL adds the register that caches the instance to the
    safepoint of the call to the DebugBreak builtin.
    
    R=clemensb@chromium.org
    
    Bug: v8:11979
    Change-Id: I7f9153e0c0e7e797b11b827111b4d61e29606071
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3063222
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76021}
    835a8b7d
liftoff-assembler.cc 49.2 KB