• Clemens Hammacher's avatar
    Move helper struct from logging.h to template-utils.h · 84dc3679
    Clemens Hammacher authored
    I want to reuse the PassType helper in another CL, thus move it from
    logging.h to template-utils.h, and rename it to pass_value_or_ref to
    match other helpers there.
    Also, add a boolean template parameter to declare whether array
    dimensions should be removed. The default is to do so, which helps to
    reduce the number of template instantiations by always passing arrays
    as pointers.
    
    Also, fix the usages in logging.h to actually use that helper when
    instantiating other template functions. This will reduce the number of
    instantiations.
    
    And finally, we now have unit tests for the template utils, to document
    what we expect, and test that this works on all architectures.
    
    R=ishell@chromium.org, tebbi@chromium.org
    
    Change-Id: I1ef5d2a489a5cfc7601c5ab13748674e3aa86cd6
    Reviewed-on: https://chromium-review.googlesource.com/594247
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47191}
    84dc3679
unittests.gyp 10.3 KB