• Eric Holk's avatar
    [wasm] enable StoreMem_offset_oob_i64 test with trap handlers · f56e2a02
    Eric Holk authored
    The first part of this change updates StoreMem_offset_oob_i64 to use one page of
    Wasm memory, rather than just a few bytes. Using less than a page was out of
    spec for Wasm anyway, so this is better.
    
    This required a small change in the test runner to set and clear the
    thread_in_wasm flag around Wasm calls. This was accomplished by a
    ThreadInWasmScope convenience class.
    
    The majority of the changes are because the cctest environment does not support
    runtime exceptions. In the code generator, where we used to throw a
    WasmMemOutOfBounds exception, we now need to call out to the test hook instead
    if runtime exceptions are not supported. This involved plumbing the
    runtime_exception_support flag down to the code generator. Rather than adding
    and shuffling around extra parameters everywhere, this CL packages the previous
    protected instruction list in a new WasmCompilationData object that now includes
    the runtime_exception_support flag as well.
    
    Bug: v8:5277
    Change-Id: Ic9c9e5a53a07a7773b58c0aee7c26bbd2ddf82f3
    Reviewed-on: https://chromium-review.googlesource.com/989017
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52368}
    f56e2a02
liftoff-compiler.cc 61 KB