• Bill Budge's avatar
    Revert "[wasm-simd][arm] Use vmov to move all ones to register" · ff503fd4
    Bill Budge authored
    This reverts commit 57242a05.
    
    Reason for revert: regression tests fails:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31477
    
    Original change's description:
    > [wasm-simd][arm] Use vmov to move all ones to register
    > 
    > vceq(dst, dst, dst) does not seem to always set the register to all
    > ones. The right way should be be to use vmov (immediate) anyway. This
    > was not supported in the assembler yet, so we need changes to the
    > assembler, diassembler, and simulator.
    > 
    > There is an unfortunate fork in logic in the simulator, due to the way
    > the switches are set up, vmov (imm) logic is duplicated across two
    > different cases, because the switch looks at the top bit of the
    > immediate. Refactoring this will be a bigger change that is irrelevant
    > for this bug, so I'm putting that off for now. Instead we extract the
    > core of vmov (imm) into helpers and call it in the two cases.
    > 
    > Bug: chromium:1112124
    > Change-Id: I283dbcd86cb0572e5ee720835f897b51fae96701
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2337503
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Bill Budge <bbudge@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69315}
    
    TBR=bbudge@chromium.org,jkummerow@chromium.org,v8-arm-ports@googlegroups.com,zhin@chromium.org
    
    Change-Id: I5d9d1dcb81771f71001d959ec5a03a43a11c4233
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1112124
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2347211Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69316}
    ff503fd4
assembler-arm.cc 181 KB