• Jakob Kummerow's avatar
    Revert "[error] extend error stack w/ function parameters" · 444741ac
    Jakob Kummerow authored
    This reverts commit 97628eee.
    
    Reason for revert: breaks compilation in Lite mode, which does not allow overriding of certain flags. See https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8926078411629093216/+/steps/build/0/steps/compile/0/stdout.
    
    Original change's description:
    > [error] extend error stack w/ function parameters
    > 
    > Extend FrameArray to hold weak references to parameters for functions in
    > the call stack. The goal here is to provide more metadata for postmortem
    > tools (such as llnode), especially in cases of rethrowing (this will be
    > particularly useful when using postmortem with promises on Node.js).
    > 
    > Besides postmortem, these changes allow us to print a more detailed
    > stack trace for errors with parameters types (or even values), which can
    > be useful since JavaScript functions can receive any number of
    > parameters of any type, and having a function behave differently
    > according to the number of parameters received as well as their types is
    > a common pattern on JS libraries and frameworks.
    > 
    > R=​bmeurer@google.com, yangguo@google.com
    > 
    > Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61
    > Reviewed-on: https://chromium-review.googlesource.com/c/1289489
    > Commit-Queue: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58468}
    
    TBR=yangguo@chromium.org,bmeurer@google.com,bmeurer@chromium.org,mat@mmarchini.me
    
    Change-Id: Ide0a434c1521ab2bbeca6821397ff63ba7d40fe5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1390128Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58469}
    444741ac
flag-definitions.h 64.9 KB