• Dominik Inführ's avatar
    [heap] Add shared barrier to RecordWrite builtin · c5d48121
    Dominik Inführ authored
    This CL adds the shared barrier to the RecordWrite builtin which is
    used in generated code for builtins, interpreted and optimized code.
    
    The out-of-line part of the barrier now checks whether either the
    POINTERS_TO_HERE_ARE_INTERESTING or the IN_SHARED_HEAP bit is set in
    the value object's page flags.
    
    Outside of marking the RecordWrite builtin now needs to check whether
    to insert into the generational or shared remembered set. Inserting
    into the shared remembered set will always call into C++ code.
    
    During marking the RecordWrite builtin now also needs to check whether
    this store created an old-to-shared pointer.
    
    Bug: v8:11708
    Change-Id: Iaca4c3c0650aece4326936d7d63754a23cd0a028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779679Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82375}
    c5d48121
heap-write-barrier.h 3.79 KB