• Seth Brenith's avatar
    [torque] Generate better code when using `&` operator on bitfields · 98438d86
    Seth Brenith authored
    Sometimes CSA code carefully constructs a mask to check several
    bitfields at once. Thus far, such a check has been very awkward to write
    in Torque. This change adds a way to do so, using the
    non-short-circuiting binary `&` operator. So now you can write an
    expression that depends on several bitfields from a bitfield struct,
    like `x.a == 5 & x.b & !x.c & x.d == 2` (assuming b is a one-bit value),
    and it will be reduced to a single mask and equality check. To
    demonstrate a usage of this new reduction, this change ports the trivial
    macro IsSimpleObjectMap to Torque. I manually verified that the
    generated code for the builtin SetDataProperties, which uses that macro,
    is unchanged.
    
    Bug: v8:7793
    Change-Id: I4a23e0005d738a6699ea0f2a63f9fd67b01e7026
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183276
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67948}
    98438d86
map.tq 2.89 KB