• Michael Lippautz's avatar
    cppgc: Do not run stack verification with TSAN · 806a207f
    Michael Lippautz authored
    Avoid verifying the stack when running with TSAN as the TSAN runtime
    changes stack contents when e.g. working with locks.
    
    Specifically, the marker uses locks in slow path operations which
    results in stack changes throughout marking. This means that the
    conservative iteration in the verifier may find more objects then the
    regular marker. The difference is benign as the delta of objects is
    not reachable from user code but it prevents verification.
    
    Bug: chromium:1275581
    Change-Id: Ie316ab65a5b90a1b72c09966f72d61af91224091
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3317976
    Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78260}
    806a207f
marking-verifier.cc 6.81 KB