• Darius M's avatar
    [compiler] Better code generation for branches on binops · 02fc37d3
    Darius M authored
    Commit 0719ace6 improves the code
    generated for comparisons by avoiding the materalization of the
    comparison bit.
    
    Now, this commit aims at doing this same improvement for binary
    operations. Since binary operations set the ZF flag, there is no
    reason to insert a "== 0" comparison.
    
    Note that this commit might increase register pressure, which might
    actually reduce performance. It's hard to anticipate, so we'll land
    it, and revert it if it's actually bad for performance.
    
    
    Bug: v8:12484
    Change-Id: I963f0c4afdd59b35b4bac468e47d987836433163
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545165Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79611}
    02fc37d3
branch-condition-duplicator.cc 3.04 KB