-
Dan Elphick authored
This marks the following methods as V8_DEPRECATE_SOON and adds new versions that take Isolate* as their first parameter: PrimitiveArray::Set PrimitiveArray::Get StackTrace::GetFrame String::Write String::WriteOneByte String::WriteUtf8 String::Concat StringObject::New Additionally StackFrameInfo, Module and TemplateInfo are marked as NeverReadOnlySpaceObject so their GetIsolates calls are safe. In api.cc, ContextFromHeapObject is split into ContextFromNeverReadOnlySpaceObject and UnsafeContextFromHeapObject, where the latter uses the deprecated methods but is only called from methods that were themselves already marked V8_DEPRECATE_SOON. Deprecation warnings for using HeapObject::GetHeap/GetIsolate are suppressed for all the uses in V8_DEPRECATE_SOON methods so that stats produced using tools/collect_deprecation_stats.sh don't show them. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I48799b5599711661b14d0cd04f21a0a00322da4a Reviewed-on: https://chromium-review.googlesource.com/1136641 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54469}
8a011b57