• Sigurd Schneider's avatar
    Reland "[code-comments] Put code comments into the code object" · ed3d6472
    Sigurd Schneider authored
    This is a reland of e774cffe
    
    This reland disables a test as v8:8548 is blocking it, which was
    broken by a recent CL. CQ did not catch this because the merge-base
    CQ used did not yet contain the CL that caused v8:8548.
    
    Original change's description:
    > [code-comments] Put code comments into the code object
    >
    > Code comments in the snapshot can now be enabled with gn
    > arg 'v8_enable_snapshot_code_comments'
    >
    > Bug: v8:7989
    > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1329173
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58020}
    
    TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Bug: v8:7989, v8:8548
    Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361166Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58028}
    ed3d6472
assembler-arm.cc 176 KB