• Michael Achenbach's avatar
    [foozzie] Align running main comparisons and smoke tests · ca674858
    Michael Achenbach authored
    This shares the code of running the comparisons on the fuzz test
    and on the smoke tests. While this change retains behavior for running
    the fuzz test, the smoke test has slight changes in favor of code
    readability:
    
    1. Smoke tests can now bail out on output suppressions (There are
    none now. And if we'd ever add any we'd need to write them in a way,
    such that they ignore the output of the smoke tests, which don't
    have much output anyways).
    2. Crashes in smoke tests are now a hard failure. This is a desired
    feature anyways. It's unlikely that the smoke test crashes as then
    nothing would work.
    
    No-Try: true
    Bug: chromium:1100114
    Change-Id: Ice3c6d18b549727c486a70756a72038c8b2029ac
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273125
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Reviewed-by: 's avatarLiviu Rau <liviurau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68586}
    ca674858
sanity_check_output.txt 1.25 KB