• Milad Farazmand's avatar
    PPC/s390: Reland "[wasm][debug] Fix tier down during streaming compilation" · 630bad76
    Milad Farazmand authored
    Port 18ac08d0
    
    Original Commit Message:
    
        This is a reland of 3cc981cb with a
        fix for data race detected by TSan.
    
        Original change's description:
        > [wasm][debug] Fix tier down during streaming compilation
        >
        > If the debugger is enabled while streaming compilation is happening, we
        > won't correctly tier down to Liftoff. This is because during streaming
        > compilation, we always compile for no debugging. Fixing that is a bit
        > tricky, since when the debugger is enabled, functions can either already
        > have finished compiling, or they are currently being compiled, or their
        > wire bytes are not received yet.
        > Instead of handling this correctly while streaming compilation is
        > running, we just recompile the whole module with Liftoff after streaming
        > compilation finished.
        >
        > For testing this, we use the existing tests for async compilation, and
        > enable --wasm-test-streaming, which compiles via the streaming decoder
        > even in the async compilation case.
        >
        > R=thibaudm@chromium.org
        >
        > Bug: v8:10531
        > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
        > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133
        > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
        > Commit-Queue: Clemens Backes <clemensb@chromium.org>
        > Cr-Commit-Position: refs/heads/master@{#67882}
    
    R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: I778a10eaba0016a9e897c8f71ac822c6b421350f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208901
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67906}
    630bad76
debugger.status 6.1 KB