• Ross McIlroy's avatar
    Revert "[Ast] Teach Ast Printer to print raw literal values." · 5dc02ef2
    Ross McIlroy authored
    This reverts commit c60934e9.
    
    Reason for revert: breaks nosnap build
    
    
    Original change's description:
    > [Ast] Teach Ast Printer to print raw literal values.
    > 
    > Converts the ast prettyprinter to printing literals from the raw values
    > rather than internalized on-heap strings. This enables ast printing before
    > internalizing, and means we can avoid use of the isolate in the interpreter's
    > off-thread phase.
    > 
    > Also removes --print-builtin-ast and relies on just --print-ast to print
    > everything.
    > 
    > Finally, converts FunctionLiteral's debug_name function to return a
    > char[] which is created from the raw name literal where it exists, rather
    > than relying on the value having been internalized.
    > 
    > BUG=v8:5203
    > 
    > Change-Id: I0e358d6acc9ae4516ed49e7a763e208fea5fcf66
    > Reviewed-on: https://chromium-review.googlesource.com/749261
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49119}
    
    TBR=rmcilroy@chromium.org,adamk@chromium.org
    
    Change-Id: Ic9d511f5107666a2f6a2bf59d8e93643c32d4d2b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:5203
    Reviewed-on: https://chromium-review.googlesource.com/753627Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49120}
    5dc02ef2
ast.cc 29.3 KB