• jameslahm's avatar
    Reland "[web snapshot] Add support for object with dictionary mode" · e43cfdd8
    jameslahm authored
    This is a reland of commit 507fa4d7
    
    This CL moves the NewJSObjectFromMap after deserializing object properties with dictionary map and fixes the DCHECK failure in JSReceiver::HasFastProperties when triggering GC.
    
    Original change's description:
    > [web snapshot] Add support for object with dictionary mode
    >
    > This CL adds the serialization support for object properties
    > with dictionary map. Shape id is used to distinguish between if the object has dictionary map. And add TODO to support “no map objects” which can have fast map and “objects with map” which needs to be turned to dictionary mode.
    >
    > Bug: v8:11525
    > Change-Id: If3eb4195115a41d4a3f6cc7372924b982ca96fc1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3621593
    > Commit-Queue: 王澳 <wangao.james@bytedance.com>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#80366}
    
    Bug: v8:11525
    Change-Id: I88422d698aa03fb7d3b21b5709eec2d0cf306256
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629738
    Commit-Queue: 王澳 <wangao.james@bytedance.com>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80374}
    e43cfdd8
web-snapshot.cc 102 KB