• Leszek Swirski's avatar
    [maglev] Add DCHECKs around input clobbering/eager deopts · 25d6463b
    Leszek Swirski authored
    DCHECK that input registers that are clobbered (e.g. because they are
    also an output register) are not used as register inputs into eager
    deopts.
    
    This is already the case because we're only allowed to mutate input
    registers that alias the result register, and eager deopt input
    allocation happens after result register allocation, but this DCHECK
    makes this assumption explicit and will break if we ever change the
    regalloc.
    
    Bug: v8:7700
    Change-Id: I4e00a8be88e0984044d8fc5b661eaf7bea801b17
    Fixed: v8:13278
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905189
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83330}
    25d6463b
maglev-ir.h 130 KB