• Jose Dapena Paz's avatar
    [profiler][etw] Simplify method name passed to ETW. · b2638151
    Jose Dapena Paz authored
    In existing implementation, of MethodLoad event,
    the method name passed to ETW is coming from
    CodeEventLogger::CodeCreateEvent, and includes
    the source file or URL, column and line numbers, method name
    and a marker for the kind of code generation.
    
    This is partially redundant, as the reference to source ID
    will point to the already generated SourceLoad event, with
    the file information. Also, Windows Performance Analyzer will
    already pick line and column number for the stack representation.
    
    So, for those cases, we just need to send to ETW the script
    method name. Even better, this changeset uses the DebugNameCStr
    logic to retrieve the inferred name in case there is no name
    available.
    
    Bug: v8:12987
    Change-Id: If09c1fedc9da158a3c72932655e2e6b09e818d93
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763862Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: José Dapena Paz <jdapena@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#82555}
    b2638151
etw-jit-win.cc 12.4 KB