• kozyatinskiy's avatar
    [inspector] implemented blackboxing inside v8 · ac50c79a
    kozyatinskiy authored
    V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation.
    Advantages:
    - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step),
    - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps,
    - simplification of debugger agent logic.
    Disadvtanges:
    - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side.
    
    Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing
    
    BUG=v8:5842
    R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org
    
    Review-Url: https://codereview.chromium.org/2633803002
    Cr-Commit-Position: refs/heads/master@{#42614}
    ac50c79a
v8-debugger.h 7.03 KB