• Camillo Bruni's avatar
    Reland "[runtime] Use Isolate::ThrowAt with MessageLocation" · 447915ef
    Camillo Bruni authored
    This is a reland of eb6b4ce1
    
    Skip test that serializes Error which references a Script. All errors
    created by ThrowAt store the current Script under the
    error_script_symbol.
    
    Original change's description:
    > [runtime] Use Isolate::ThrowAt with MessageLocation
    >
    > Fix various missing source positions when reporting parse and compile
    > errors. Namely this fixes missing source positions when having invalid
    > module imports.
    >
    > - Use Isolate::ThrowAt with valid MessageLocation objects
    > - Change public Isolate::Throw to no longer accept MessageLocation to
    >   avoid misues
    > - Introduce private Isolate::ThrowInternal that accepts MessageLocation
    >
    > Bug: v8:6513
    > Change-Id: I3ee633c9fff8c9d361bddb37f56e28a50c280ec1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467839
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70623}
    
    Bug: v8:6513
    Change-Id: Icba74f74178e28fbda0fd0c237eeb7bacbc33570
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487123Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70741}
    447915ef
execution.cc 22.1 KB